Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameter create_mpc_if_alone in MPC Add Participant API #254

Merged
merged 5 commits into from
Jan 25, 2024
Merged

New parameter create_mpc_if_alone in MPC Add Participant API #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7f439c
New parameter `create_mpc_if_alone` in MPC Add Participant API
Abinaya-Shunmugavel Jan 17, 2024
0dc0494
fixed existing UT bug
Abinaya-Shunmugavel Jan 17, 2024
07efba4
param name change
Abinaya-Shunmugavel Jan 18, 2024
fc97642
parameter name change
Abinaya-Shunmugavel Jan 18, 2024
9abea7e
adding the changes
eniyavan-muruganantham-plivo Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Change Log
## [4.47.2](https://github.com/plivo/plivo-python/tree/v4.47.2) (2024-01-25)
**Added new params 'create_mpc_with_single_participant' for Add Participant API of MPC**

## [4.47.1](https://github.com/plivo/plivo-python/tree/v4.47.1) (2023-12-19)
**Type param addition in speak api for call and mpc**

Expand Down
7 changes: 5 additions & 2 deletions plivo/resources/multipartycall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ def add_participant(self,
start_recording_audio=None,
start_recording_audio_method='GET',
stop_recording_audio=None,
stop_recording_audio_method='GET'
stop_recording_audio_method='GET',
create_mpc_with_single_participant=True
):
return self.client.multi_party_calls.add_participant(role, uuid=self.id,
**to_param_dict(self.add_participant, locals()))
Expand Down Expand Up @@ -334,6 +335,7 @@ def get(self, uuid=None, friendly_name=None, callback_url=None, callback_method=
stop_recording_audio_method=[optional(of_type_exact(str), is_in(('GET', 'POST'), case_sensitive=False))],
callback_url=[optional(is_url())],
callback_method=[optional(of_type(six.text_type))],
create_mpc_with_single_participant=[optional(of_type_exact(bool))],
)
def add_participant(self,
role,
Expand Down Expand Up @@ -387,7 +389,8 @@ def add_participant(self,
stop_recording_audio=None,
stop_recording_audio_method='GET',
callback_url=None,
callback_method=None
callback_method=None,
create_mpc_with_single_participant=True
):
mpc_id = self.__make_mpc_id(friendly_name, uuid)
caller_name = caller_name or from_
Expand Down
2 changes: 1 addition & 1 deletion plivo/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# -*- coding: utf-8 -*-
__version__ = '4.47.1'
__version__ = '4.47.2'
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

setup(
name='plivo',
version='4.47.0',
version='4.47.2',
description='A Python SDK to make voice calls & send SMS using Plivo and to generate Plivo XML',
long_description=long_description,
url='https://github.com/plivo/plivo-python',
Expand Down
1 change: 1 addition & 0 deletions tests/resources/test_multipartycalls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ def test_add_participant(self):
'role': 'agent',
'start_recording_audio_method': 'GET',
'stop_recording_audio_method': 'GET',
'create_mpc_with_single_participant': True
}

add_participant_response = self.client.multi_party_calls.add_participant(friendly_name='Voice', role='agent',
Expand Down
2 changes: 1 addition & 1 deletion tests/xml/test_responseElement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def test_add_mpc(self):
'enterSoundMethod="GET" exitSound="beep:1" exitSoundMethod="GET" hold="true" ' \
'maxDuration="20000" maxParticipants="7" mute="true" onExitActionMethod="POST" ' \
'onExitActionUrl="https://plivo.com/exitAction" record="true" recordFileFormat="wav" ' \
'recordMinMemberCount="1" recordingCallbackMethod="GET" ' \
'recordMinMemberCount="1" recordParticipantTrack="false" recordingCallbackMethod="GET" ' \
'relayDTMFInputs="false" role="customer" ' \
'startMpcOnEnter="true" '\
'startRecordingAudio="https://plivo.com/plivoTone.mp3" ' \
Expand Down
Loading