Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK changes for Import Campaign API #259

Merged
merged 10 commits into from
Mar 13, 2024
Merged

SDK changes for Import Campaign API #259

merged 10 commits into from
Mar 13, 2024

Conversation

vinaykumar-plivo
Copy link
Contributor

No description provided.

@Sajal-Singhal
Copy link

@vinaykumar-plivo can you push version upgrade files changes as well

Copy link
Contributor

@rajneeshkatkam-plivo rajneeshkatkam-plivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add version update changes

Copy link
Contributor

@narayana-plivo narayana-plivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from minor comment

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.76%. Comparing base (612e582) to head (87786a2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   82.75%   82.76%   +0.01%     
==========================================
  Files          77       77              
  Lines        5010     5013       +3     
==========================================
+ Hits         4146     4149       +3     
  Misses        864      864              
Flag Coverage Δ
unittests 82.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@narayana-plivo narayana-plivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the review comment

@msk-plivo msk-plivo merged commit 412e40f into master Mar 13, 2024
14 of 15 checks passed
@msk-plivo msk-plivo deleted the SMS-6644 branch March 13, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants