Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken GPL license link in footer template #4109

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

rohnsha0
Copy link
Contributor

@rohnsha0 rohnsha0 commented Feb 14, 2025

ref #4108

@rohnsha0 rohnsha0 requested a review from stevepiercy February 14, 2025 08:43
@ale-rt
Copy link
Member

ale-rt commented Feb 14, 2025

@jenkins-plone-org please run jobs

Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@stevepiercy
Copy link
Contributor

Please change Fixes #4108 to Refs #4108 because there are multiple places this needs to be fixed, and we shouldn't close that issue until all of them are in fact fixed, including plone.org and all demos.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the PR description edit so it doesn't close the parent issue when merged.

@ale-rt
Copy link
Member

ale-rt commented Feb 14, 2025

@jenkins-plone-org please run jobs

Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job, could you also please make a PR for the 6.1.x and 6.0.x branches?

Thank you very much for your contribution!

@ale-rt
Copy link
Member

ale-rt commented Feb 14, 2025

@jenkins-plone-org please run jobs

@rohnsha0
Copy link
Contributor Author

is there something wrong with Jenkens? @plone/ai-team

@fredvd
Copy link
Member

fredvd commented Feb 14, 2025

@rohnsha0 We are updating Jenkins at the moment, there are some issues with plugins

@rohnsha0
Copy link
Contributor Author

@rohnsha0 We are updating Jenkins at the moment, there are some issues with plugins

ah alright!

@stevepiercy
Copy link
Contributor

@jenkins-plone-org please run jobs

@stevepiercy
Copy link
Contributor

@plone/ai-team I'm not sure why Jenkins doesn't show as getting triggered in this pull request, even when manually invoking it. Maybe I misinterpret either the GitHub UI or Jenkins status. Can you advise?

@gforcada
Copy link
Member

@plone/ci-team might be the team best suited to be pinged :-)

As for Jenkins not running here: as you can see on mr.roboto branches overview master branch of CMPlone is not being used by any Plone version.

@mauritsvanrees should we already create (is already?) all the 6.2 branches on buildout.coredev and related changes that need to be done so we track CMFPlone master branch in Jenkins and mr.roboto ? 🤔

@rohnsha0 meanwhile, as @ale-rt mentioned, please port these changes to, at least, the 6.1 branch. For 6.0, I'm not sure, do we want still to send this sort of changes there? 🤔 now it is on security patches only, which these changes do not fit at all with :)

@stevepiercy
Copy link
Contributor

@rohnsha0 meanwhile, as @ale-rt mentioned, please port these changes to, at least, the 6.1 branch. For 6.0, I'm not sure, do we want still to send this sort of changes there? 🤔 now it is on security patches only, which these changes do not fit at all with :)

Our three Plone demos use 6.1, so a backport is definitely needed.

For 6.0, do we maintain any sites that use 6.0 with this footer link? I don't think we do, except possibly old PloneConf sites. I don't know which version of Plone they run, and if so whether we care to update them. IMO, their visitor counts are low, and the footer link is obscure, so I would say nope.

The most recent PloneConf site https://2024.ploneconf.org/ modified the footer and removed the link. We should do the same for 2025.

@mauritsvanrees
Copy link
Member

@mauritsvanrees should we already create (is already?) all the 6.2 branches on buildout.coredev and related changes that need to be done so we track CMFPlone master branch in Jenkins and mr.roboto ? 🤔

@gforcada Yes, the usual (PR) jobs and triggers for 6.2 on Jenkins would be welcome. The coredev 6.2 branch is already there, and for a few sources the main/master branch is already only targeting 6.2.

@mauritsvanrees
Copy link
Member

@rohnsha0 Thanks for your PR!

I will merge it and then I will simply cherry-pick the changes directly to 6.1.x and 6.0.x. No further PRs needed. I feel lucky. ;-)

@mauritsvanrees mauritsvanrees merged commit 9fd8cba into master Feb 18, 2025
2 checks passed
@mauritsvanrees mauritsvanrees deleted the rohnsha0-4108 branch February 18, 2025 18:41
@mauritsvanrees
Copy link
Member

Done in commit ff41abf (6.0.x) and commit 5b10420 (6.1.x).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants