-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update broken GPL license link in footer template #4109
Conversation
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
Please change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending the PR description edit so it doesn't close the parent issue when merged.
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jenkins-plone-org please run jobs |
is there something wrong with Jenkens? @plone/ai-team |
@rohnsha0 We are updating Jenkins at the moment, there are some issues with plugins |
ah alright! |
@jenkins-plone-org please run jobs |
@plone/ai-team I'm not sure why Jenkins doesn't show as getting triggered in this pull request, even when manually invoking it. Maybe I misinterpret either the GitHub UI or Jenkins status. Can you advise? |
@plone/ci-team might be the team best suited to be pinged :-) As for Jenkins not running here: as you can see on mr.roboto branches overview @mauritsvanrees should we already create (is already?) all the 6.2 branches on @rohnsha0 meanwhile, as @ale-rt mentioned, please port these changes to, at least, the |
Our three Plone demos use 6.1, so a backport is definitely needed. For The most recent PloneConf site https://2024.ploneconf.org/ modified the footer and removed the link. We should do the same for 2025. |
@gforcada Yes, the usual (PR) jobs and triggers for 6.2 on Jenkins would be welcome. The coredev 6.2 branch is already there, and for a few sources the main/master branch is already only targeting 6.2. |
@rohnsha0 Thanks for your PR! I will merge it and then I will simply cherry-pick the changes directly to 6.1.x and 6.0.x. No further PRs needed. I feel lucky. ;-) |
ref #4108