Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pkg_resources usage #4129

Merged
merged 3 commits into from
Mar 1, 2025
Merged

Replace pkg_resources usage #4129

merged 3 commits into from
Mar 1, 2025

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Mar 1, 2025

See #4126

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak to change log to make it clear that it's two packages replacing pkg_resources, and which may make it easier for search engines to index.

@gforcada gforcada force-pushed the drop-pkg-resources-usage branch from 0387832 to 9a4ad7e Compare March 1, 2025 12:10
@gforcada gforcada force-pushed the drop-pkg-resources-usage branch from 9a4ad7e to 2a95a6f Compare March 1, 2025 12:12
@gforcada gforcada requested a review from stevepiercy March 1, 2025 12:23
@gforcada gforcada merged commit 9153d80 into master Mar 1, 2025
8 checks passed
@gforcada gforcada deleted the drop-pkg-resources-usage branch March 1, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants