Skip to content

Commit

Permalink
[fc] Repository: plone.app.discussion
Browse files Browse the repository at this point in the history
Branch: refs/heads/main
Date: 2025-01-14T08:30:23+01:00
Author: ale-rt (ale-rt) <[email protected]>
Commit: plone/plone.app.discussion@06e8f89

Do not depend on plone.api

Refs. #188
Similar to #194

Files changed:
A news/188.bugfix.rst
M plone/app/discussion/upgrades.py
M setup.py
Repository: plone.app.discussion

Branch: refs/heads/main
Date: 2025-01-20T11:06:08+01:00
Author: Alessandro Pisa (ale-rt) <[email protected]>
Commit: plone/plone.app.discussion@4a5fa90

Merge pull request #253 from plone/no-plone-api

Do not depend on plone.api

Files changed:
A news/188.bugfix.rst
M plone/app/discussion/upgrades.py
M setup.py
  • Loading branch information
ale-rt committed Jan 20, 2025
1 parent 34790d0 commit 7c4d68e
Showing 1 changed file with 22 additions and 17 deletions.
39 changes: 22 additions & 17 deletions last_commit.txt
Original file line number Diff line number Diff line change
@@ -1,34 +1,39 @@
Repository: plone.app.querystring
Repository: plone.app.discussion


Branch: refs/heads/master
Date: 2025-01-08T11:20:45+01:00
Branch: refs/heads/main
Date: 2025-01-14T08:30:23+01:00
Author: ale-rt (ale-rt) <[email protected]>
Commit: https://github.com/plone/plone.app.querystring/commit/66db02806a8151de2e710d2dc28271dfec95601f
Commit: https://github.com/plone/plone.app.discussion/commit/06e8f894ce456b87a36dfe52a1b69d022ce049ac

Fix a not needed view call
Do not depend on plone.api

Refs. #188
Similar to #194

Files changed:
A news/+ffbbb128.bugfix.rst
M plone/app/querystring/results.pt
A news/188.bugfix.rst
M plone/app/discussion/upgrades.py
M setup.py

b'diff --git a/news/+ffbbb128.bugfix.rst b/news/+ffbbb128.bugfix.rst\nnew file mode 100644\nindex 0000000..f68dbe2\n--- /dev/null\n+++ b/news/+ffbbb128.bugfix.rst\n@@ -0,0 +1 @@\n+Fix a not needed view call\ndiff --git a/plone/app/querystring/results.pt b/plone/app/querystring/results.pt\nindex dc6ef19..2232a38 100644\n--- a/plone/app/querystring/results.pt\n+++ b/plone/app/querystring/results.pt\n@@ -8,7 +8,7 @@\n limited_results python:context[:25];\n original_context nocall:options/original_context|nocall:context;\n toLocalizedTime nocall:original_context/@@plone/toLocalizedTime;\n- pas_member original_context/@@pas_member;\n+ pas_member nocall: original_context/@@pas_member;\n normalize nocall: context/@@plone/normalizeString;\n "\n i18n:domain="plone"\n'
b'diff --git a/news/188.bugfix.rst b/news/188.bugfix.rst\nnew file mode 100644\nindex 00000000..30f44736\n--- /dev/null\n+++ b/news/188.bugfix.rst\n@@ -0,0 +1 @@\n+Do not depend on ``plone.api``. [ale-rt]\ndiff --git a/plone/app/discussion/upgrades.py b/plone/app/discussion/upgrades.py\nindex b63a666b..cab45926 100644\n--- a/plone/app/discussion/upgrades.py\n+++ b/plone/app/discussion/upgrades.py\n@@ -1,7 +1,6 @@\n from .interfaces import IDiscussionSettings\n from .setuphandlers import add_discussion_behavior_to_default_types\n from datetime import timezone\n-from plone import api\n from plone.registry.interfaces import IRegistry\n from Products.CMFCore.utils import getToolByName\n from Products.ZCatalog.ProgressHandler import ZLogHandler\n@@ -92,7 +91,7 @@ def extend_review_workflow(context):\n \n def set_timezone_on_dates(context):\n """Ensure timezone data is stored against all creation/modified dates"""\n- pc = api.portal.get_tool("portal_catalog")\n+ pc = getToolByName(context, "portal_catalog")\n creations = 0\n modifieds = 0\n logger.info("Setting timezone information on comment dates")\ndiff --git a/setup.py b/setup.py\nindex f4c4869d..558c1c69 100644\n--- a/setup.py\n+++ b/setup.py\n@@ -44,7 +44,6 @@\n "Products.GenericSetup",\n "Products.ZCatalog",\n "Products.statusmessages",\n- "plone.api",\n "plone.app.event",\n "plone.registry",\n "plone.resource",\n'

Repository: plone.app.querystring
Repository: plone.app.discussion


Branch: refs/heads/master
Date: 2025-01-19T22:02:18+01:00
Branch: refs/heads/main
Date: 2025-01-20T11:06:08+01:00
Author: Alessandro Pisa (ale-rt) <[email protected]>
Commit: https://github.com/plone/plone.app.querystring/commit/90e6c9019e52f0e0c8e9d4244ac188b4603d65e0
Commit: https://github.com/plone/plone.app.discussion/commit/4a5fa90e6cb6cb382f9099971ea90ceebc386cfe

Merge pull request #157 from plone/fix-view-call
Merge pull request #253 from plone/no-plone-api

Fix a not needed view call
Do not depend on plone.api

Files changed:
A news/+ffbbb128.bugfix.rst
M plone/app/querystring/results.pt
A news/188.bugfix.rst
M plone/app/discussion/upgrades.py
M setup.py

b'diff --git a/news/+ffbbb128.bugfix.rst b/news/+ffbbb128.bugfix.rst\nnew file mode 100644\nindex 0000000..f68dbe2\n--- /dev/null\n+++ b/news/+ffbbb128.bugfix.rst\n@@ -0,0 +1 @@\n+Fix a not needed view call\ndiff --git a/plone/app/querystring/results.pt b/plone/app/querystring/results.pt\nindex dc6ef19..2232a38 100644\n--- a/plone/app/querystring/results.pt\n+++ b/plone/app/querystring/results.pt\n@@ -8,7 +8,7 @@\n limited_results python:context[:25];\n original_context nocall:options/original_context|nocall:context;\n toLocalizedTime nocall:original_context/@@plone/toLocalizedTime;\n- pas_member original_context/@@pas_member;\n+ pas_member nocall: original_context/@@pas_member;\n normalize nocall: context/@@plone/normalizeString;\n "\n i18n:domain="plone"\n'
b'diff --git a/news/188.bugfix.rst b/news/188.bugfix.rst\nnew file mode 100644\nindex 00000000..30f44736\n--- /dev/null\n+++ b/news/188.bugfix.rst\n@@ -0,0 +1 @@\n+Do not depend on ``plone.api``. [ale-rt]\ndiff --git a/plone/app/discussion/upgrades.py b/plone/app/discussion/upgrades.py\nindex b63a666b..cab45926 100644\n--- a/plone/app/discussion/upgrades.py\n+++ b/plone/app/discussion/upgrades.py\n@@ -1,7 +1,6 @@\n from .interfaces import IDiscussionSettings\n from .setuphandlers import add_discussion_behavior_to_default_types\n from datetime import timezone\n-from plone import api\n from plone.registry.interfaces import IRegistry\n from Products.CMFCore.utils import getToolByName\n from Products.ZCatalog.ProgressHandler import ZLogHandler\n@@ -92,7 +91,7 @@ def extend_review_workflow(context):\n \n def set_timezone_on_dates(context):\n """Ensure timezone data is stored against all creation/modified dates"""\n- pc = api.portal.get_tool("portal_catalog")\n+ pc = getToolByName(context, "portal_catalog")\n creations = 0\n modifieds = 0\n logger.info("Setting timezone information on comment dates")\ndiff --git a/setup.py b/setup.py\nindex f4c4869d..558c1c69 100644\n--- a/setup.py\n+++ b/setup.py\n@@ -44,7 +44,6 @@\n "Products.GenericSetup",\n "Products.ZCatalog",\n "Products.statusmessages",\n- "plone.api",\n "plone.app.event",\n "plone.registry",\n "plone.resource",\n'

0 comments on commit 7c4d68e

Please sign in to comment.