Skip to content

Commit

Permalink
[fc] Repository: plone.app.dexterity
Browse files Browse the repository at this point in the history
Branch: refs/heads/master
Date: 2023-10-31T20:50:53+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.dexterity@e9466e8

Make the dependency on plone.app.content conditional.

This is for `INameFromTitle`, which we want to move to `plone.base`.
See plone/plone.app.dexterity#379 (comment) for why this is not working yet, and we need this workaround.

Files changed:
A news/3858.internal
M .meta.toml
M plone/app/dexterity/behaviors/configure.zcml
M pyproject.toml
M setup.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2023-10-31T22:17:23+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.dexterity@d4ebbe1

Test that both spellings of the plone.namefromtitle behavior work.

Both `plone.namefromtitle` and `plone.app.content.interfaces.INameFromTitle` work.
You cannot use `plone.base.interfaces.INameFromTitle` as behavior name, this was never supported.
Recommended is to use `plone.namefromtitle` in all supported Plone versions.
Using `plone.app.content.interfaces.INameFromTitle` as name will stop working in Plone 7.

Rewrote the `tests/namefromtitle.txt` doctest file as a unittest file, making it easier to test both behavior names.

Files changed:
A plone/app/dexterity/tests/test_namefromtitle.py
M plone/app/dexterity/behaviors/configure.zcml
M plone/app/dexterity/tests/test_doctests.py
D plone/app/dexterity/tests/namefromtitle.txt
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2023-11-02T11:54:24+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.app.dexterity@669e1e7

Merge pull request #380 from plone/maurits-plone-app-content-conditional

Make the dependency on plone.app.content conditional.

Files changed:
A news/3858.internal
A plone/app/dexterity/tests/test_namefromtitle.py
M .meta.toml
M plone/app/dexterity/behaviors/configure.zcml
M plone/app/dexterity/tests/test_doctests.py
M pyproject.toml
M setup.py
D plone/app/dexterity/tests/namefromtitle.txt
  • Loading branch information
mauritsvanrees committed Nov 2, 2023
1 parent d3e17e4 commit 8abbf95
Showing 1 changed file with 39 additions and 117 deletions.
156 changes: 39 additions & 117 deletions last_commit.txt

Large diffs are not rendered by default.

0 comments on commit 8abbf95

Please sign in to comment.