Skip to content

Commit

Permalink
[fc] Repository: Products.PlonePAS
Browse files Browse the repository at this point in the history
Branch: refs/heads/master
Date: 2024-12-20T16:49:15+01:00
Author: ale-rt (ale-rt) <[email protected]>
Commit: plone/Products.PlonePAS@18bbb49

Return an error when trying to access the pas views from the web

Files changed:
A news/94.bugfix.rst
M src/Products/PlonePAS/browser/configure.zcml
M src/Products/PlonePAS/browser/info.py
M src/Products/PlonePAS/browser/member.py
M src/Products/PlonePAS/browser/search.py
Repository: Products.PlonePAS

Branch: refs/heads/master
Date: 2025-01-20T14:51:39+01:00
Author: Alessandro Pisa (ale-rt) <[email protected]>
Commit: plone/Products.PlonePAS@87e119d

Merge pull request #95 from plone/remove-allowed-interface

Return an error when trying to access the pas views from the web

Files changed:
A news/94.bugfix.rst
M src/Products/PlonePAS/browser/configure.zcml
M src/Products/PlonePAS/browser/info.py
M src/Products/PlonePAS/browser/member.py
M src/Products/PlonePAS/browser/search.py
  • Loading branch information
ale-rt committed Jan 20, 2025
1 parent 36d9f34 commit b35bbda
Showing 1 changed file with 21 additions and 15 deletions.
36 changes: 21 additions & 15 deletions last_commit.txt
Original file line number Diff line number Diff line change
@@ -1,34 +1,40 @@
Repository: plone.app.querystring
Repository: Products.PlonePAS


Branch: refs/heads/master
Date: 2025-01-08T11:20:45+01:00
Date: 2024-12-20T16:49:15+01:00
Author: ale-rt (ale-rt) <[email protected]>
Commit: https://github.com/plone/plone.app.querystring/commit/66db02806a8151de2e710d2dc28271dfec95601f
Commit: https://github.com/plone/Products.PlonePAS/commit/18bbb49b017a32dbf2cd053cf5eb07fb9cdb5787

Fix a not needed view call
Return an error when trying to access the pas views from the web

Files changed:
A news/+ffbbb128.bugfix.rst
M plone/app/querystring/results.pt
A news/94.bugfix.rst
M src/Products/PlonePAS/browser/configure.zcml
M src/Products/PlonePAS/browser/info.py
M src/Products/PlonePAS/browser/member.py
M src/Products/PlonePAS/browser/search.py

b'diff --git a/news/+ffbbb128.bugfix.rst b/news/+ffbbb128.bugfix.rst\nnew file mode 100644\nindex 0000000..f68dbe2\n--- /dev/null\n+++ b/news/+ffbbb128.bugfix.rst\n@@ -0,0 +1 @@\n+Fix a not needed view call\ndiff --git a/plone/app/querystring/results.pt b/plone/app/querystring/results.pt\nindex dc6ef19..2232a38 100644\n--- a/plone/app/querystring/results.pt\n+++ b/plone/app/querystring/results.pt\n@@ -8,7 +8,7 @@\n limited_results python:context[:25];\n original_context nocall:options/original_context|nocall:context;\n toLocalizedTime nocall:original_context/@@plone/toLocalizedTime;\n- pas_member original_context/@@pas_member;\n+ pas_member nocall: original_context/@@pas_member;\n normalize nocall: context/@@plone/normalizeString;\n "\n i18n:domain="plone"\n'
b'diff --git a/news/94.bugfix.rst b/news/94.bugfix.rst\nnew file mode 100644\nindex 00000000..679953ee\n--- /dev/null\n+++ b/news/94.bugfix.rst\n@@ -0,0 +1 @@\n+Return an error when trying to access the pas views from the web [ale-rt]\ndiff --git a/src/Products/PlonePAS/browser/configure.zcml b/src/Products/PlonePAS/browser/configure.zcml\nindex f6cac731..f99dfd33 100644\n--- a/src/Products/PlonePAS/browser/configure.zcml\n+++ b/src/Products/PlonePAS/browser/configure.zcml\n@@ -14,7 +14,6 @@\n name="pas_info"\n for="*"\n class=".info.PASInfoView"\n- allowed_interface="Products.PlonePAS.interfaces.browser.IPASInfoView"\n permission="zope2.View"\n />\n \n@@ -22,7 +21,6 @@\n name="pas_member"\n for="*"\n class=".member.PASMemberView"\n- allowed_interface="Products.PlonePAS.interfaces.browser.IPASMemberView"\n permission="zope2.View"\n />\n \n@@ -30,7 +28,6 @@\n name="pas_search"\n for="*"\n class=".search.PASSearchView"\n- allowed_interface="Products.PlonePAS.interfaces.browser.IPASSearchView"\n permission="zope2.View"\n />\n \ndiff --git a/src/Products/PlonePAS/browser/info.py b/src/Products/PlonePAS/browser/info.py\nindex 04e2fc84..d56326d9 100644\n--- a/src/Products/PlonePAS/browser/info.py\n+++ b/src/Products/PlonePAS/browser/info.py\n@@ -7,6 +7,7 @@\n from Products.PluggableAuthService.interfaces.plugins import ( # noqa: E501\n ILoginPasswordExtractionPlugin,\n )\n+from zExceptions import HTTPImATeapot\n from zope.interface import implementer\n \n \n@@ -38,3 +39,6 @@ def hasOpenIDExtractor(self):\n def hasOpenIDdExtractor(self):\n # BBB Keeping method name with typo for backwards compatibility.\n return self.hasOpenIDExtractor()\n+\n+ def __call__(self):\n+ raise HTTPImATeapot("View not callable")\ndiff --git a/src/Products/PlonePAS/browser/member.py b/src/Products/PlonePAS/browser/member.py\nindex 8559cb5a..9c99f1d3 100644\n--- a/src/Products/PlonePAS/browser/member.py\n+++ b/src/Products/PlonePAS/browser/member.py\n@@ -1,6 +1,7 @@\n from plone.memoize.instance import memoize\n from Products.CMFCore.utils import getToolByName\n from Products.PlonePAS.interfaces.browser import IPASMemberView\n+from zExceptions import HTTPImATeapot\n from zope.interface import implementer\n from zope.publisher.browser import BrowserView\n \n@@ -26,3 +27,6 @@ def info(self, userid=None):\n result.get("fullname") or result.get("username") or userid\n )\n return result\n+\n+ def __call__(self):\n+ raise HTTPImATeapot("View not callable")\ndiff --git a/src/Products/PlonePAS/browser/search.py b/src/Products/PlonePAS/browser/search.py\nindex 587d0401..74251617 100644\n--- a/src/Products/PlonePAS/browser/search.py\n+++ b/src/Products/PlonePAS/browser/search.py\n@@ -2,6 +2,7 @@\n from Products.CMFCore.utils import getToolByName\n from Products.Five import BrowserView\n from Products.PlonePAS.interfaces.browser import IPASSearchView\n+from zExceptions import HTTPImATeapot\n from zope.component import queryUtility\n from zope.interface import implementer\n \n@@ -73,3 +74,6 @@ def getPhysicalPath(self):\n # persistent object. So we fake things and return the physical path\n # for our context.\n return self.context.getPhysicalPath()\n+\n+ def __call__(self):\n+ raise HTTPImATeapot("View not callable")\n'

Repository: plone.app.querystring
Repository: Products.PlonePAS


Branch: refs/heads/master
Date: 2025-01-19T22:02:18+01:00
Date: 2025-01-20T14:51:39+01:00
Author: Alessandro Pisa (ale-rt) <[email protected]>
Commit: https://github.com/plone/plone.app.querystring/commit/90e6c9019e52f0e0c8e9d4244ac188b4603d65e0
Commit: https://github.com/plone/Products.PlonePAS/commit/87e119deb10b63b587868d0b4d22a48af26afd09

Merge pull request #157 from plone/fix-view-call
Merge pull request #95 from plone/remove-allowed-interface

Fix a not needed view call
Return an error when trying to access the pas views from the web

Files changed:
A news/+ffbbb128.bugfix.rst
M plone/app/querystring/results.pt
A news/94.bugfix.rst
M src/Products/PlonePAS/browser/configure.zcml
M src/Products/PlonePAS/browser/info.py
M src/Products/PlonePAS/browser/member.py
M src/Products/PlonePAS/browser/search.py

b'diff --git a/news/+ffbbb128.bugfix.rst b/news/+ffbbb128.bugfix.rst\nnew file mode 100644\nindex 0000000..f68dbe2\n--- /dev/null\n+++ b/news/+ffbbb128.bugfix.rst\n@@ -0,0 +1 @@\n+Fix a not needed view call\ndiff --git a/plone/app/querystring/results.pt b/plone/app/querystring/results.pt\nindex dc6ef19..2232a38 100644\n--- a/plone/app/querystring/results.pt\n+++ b/plone/app/querystring/results.pt\n@@ -8,7 +8,7 @@\n limited_results python:context[:25];\n original_context nocall:options/original_context|nocall:context;\n toLocalizedTime nocall:original_context/@@plone/toLocalizedTime;\n- pas_member original_context/@@pas_member;\n+ pas_member nocall: original_context/@@pas_member;\n normalize nocall: context/@@plone/normalizeString;\n "\n i18n:domain="plone"\n'
b'diff --git a/news/94.bugfix.rst b/news/94.bugfix.rst\nnew file mode 100644\nindex 00000000..679953ee\n--- /dev/null\n+++ b/news/94.bugfix.rst\n@@ -0,0 +1 @@\n+Return an error when trying to access the pas views from the web [ale-rt]\ndiff --git a/src/Products/PlonePAS/browser/configure.zcml b/src/Products/PlonePAS/browser/configure.zcml\nindex f6cac731..f99dfd33 100644\n--- a/src/Products/PlonePAS/browser/configure.zcml\n+++ b/src/Products/PlonePAS/browser/configure.zcml\n@@ -14,7 +14,6 @@\n name="pas_info"\n for="*"\n class=".info.PASInfoView"\n- allowed_interface="Products.PlonePAS.interfaces.browser.IPASInfoView"\n permission="zope2.View"\n />\n \n@@ -22,7 +21,6 @@\n name="pas_member"\n for="*"\n class=".member.PASMemberView"\n- allowed_interface="Products.PlonePAS.interfaces.browser.IPASMemberView"\n permission="zope2.View"\n />\n \n@@ -30,7 +28,6 @@\n name="pas_search"\n for="*"\n class=".search.PASSearchView"\n- allowed_interface="Products.PlonePAS.interfaces.browser.IPASSearchView"\n permission="zope2.View"\n />\n \ndiff --git a/src/Products/PlonePAS/browser/info.py b/src/Products/PlonePAS/browser/info.py\nindex 04e2fc84..d56326d9 100644\n--- a/src/Products/PlonePAS/browser/info.py\n+++ b/src/Products/PlonePAS/browser/info.py\n@@ -7,6 +7,7 @@\n from Products.PluggableAuthService.interfaces.plugins import ( # noqa: E501\n ILoginPasswordExtractionPlugin,\n )\n+from zExceptions import HTTPImATeapot\n from zope.interface import implementer\n \n \n@@ -38,3 +39,6 @@ def hasOpenIDExtractor(self):\n def hasOpenIDdExtractor(self):\n # BBB Keeping method name with typo for backwards compatibility.\n return self.hasOpenIDExtractor()\n+\n+ def __call__(self):\n+ raise HTTPImATeapot("View not callable")\ndiff --git a/src/Products/PlonePAS/browser/member.py b/src/Products/PlonePAS/browser/member.py\nindex 8559cb5a..9c99f1d3 100644\n--- a/src/Products/PlonePAS/browser/member.py\n+++ b/src/Products/PlonePAS/browser/member.py\n@@ -1,6 +1,7 @@\n from plone.memoize.instance import memoize\n from Products.CMFCore.utils import getToolByName\n from Products.PlonePAS.interfaces.browser import IPASMemberView\n+from zExceptions import HTTPImATeapot\n from zope.interface import implementer\n from zope.publisher.browser import BrowserView\n \n@@ -26,3 +27,6 @@ def info(self, userid=None):\n result.get("fullname") or result.get("username") or userid\n )\n return result\n+\n+ def __call__(self):\n+ raise HTTPImATeapot("View not callable")\ndiff --git a/src/Products/PlonePAS/browser/search.py b/src/Products/PlonePAS/browser/search.py\nindex 587d0401..74251617 100644\n--- a/src/Products/PlonePAS/browser/search.py\n+++ b/src/Products/PlonePAS/browser/search.py\n@@ -2,6 +2,7 @@\n from Products.CMFCore.utils import getToolByName\n from Products.Five import BrowserView\n from Products.PlonePAS.interfaces.browser import IPASSearchView\n+from zExceptions import HTTPImATeapot\n from zope.component import queryUtility\n from zope.interface import implementer\n \n@@ -73,3 +74,6 @@ def getPhysicalPath(self):\n # persistent object. So we fake things and return the physical path\n # for our context.\n return self.context.getPhysicalPath()\n+\n+ def __call__(self):\n+ raise HTTPImATeapot("View not callable")\n'

0 comments on commit b35bbda

Please sign in to comment.