-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use current ZODB (3rd trial) #324
Conversation
Ok, this shows that the original commit already comes with the problem. @plone/testing-team and @jimfulton any idea why it fails so badly here? |
On Wed, Apr 12, 2017 at 10:50 AM, Jens W. Klein ***@***.***> wrote:
Ok, this shows that the original commit already comes with the problem.
As it was green at some point it must be something introduced later.
@plone/testing-team <https://github.com/orgs/plone/teams/testing-team>
and @jimfulton <https://github.com/jimfulton> any idea why it fails so
badly here?
I'm confused. The tests were passing and now aren't.
I just ran the non-selenium tests (/bin/alltsests) on use-current-zodb-3 on
my mac and they all passed.
Total time elapsed: 1585.193 seconds
Grand total: 90 packages, 0 failures
Are the failures selenium tests?
I'll try on linux via a docker container.
|
On Wed, Apr 12, 2017 at 11:47 AM, Jim Fulton ***@***.***> wrote:
On Wed, Apr 12, 2017 at 10:50 AM, Jens W. Klein ***@***.***>
wrote:
> Ok, this shows that the original commit already comes with the problem.
> As it was green at some point it must be something introduced later.
>
> @plone/testing-team <https://github.com/orgs/plone/teams/testing-team>
> and @jimfulton <https://github.com/jimfulton> any idea why it fails so
> badly here?
>
I'm confused. The tests were passing and now aren't.
I just ran the non-selenium tests (/bin/alltsests) on use-current-zodb-3
on my mac and they all passed.
Total time elapsed: 1585.193 seconds
Grand total: 90 packages, 0 failures
Are the failures selenium tests?
I'll try on linux via a docker container.
I ran the tests in a linux container. I'm actually unsure how to interpret
results from bin/alltests.
The summary:
Packages with test failures:
Failing tests in group plone_app_testing
Total time elapsed: 1474.068 seconds
Grand total: 90 packages, 1 failures
But if I scroll up:
Error in test testNormalizeLatin1
(Products.CMFPlone.tests.testUnicodeSplitter.TestCaseNormalizer)
Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 329, in run
testMethod()
File
"/home/jim/p/plone/buildout.coredev/src/Products.CMFPlone/Products/CMFPlone/tests/testUnicodeSplitter.py",
line 127, in testNormalizeLatin1
saved = _setlocale(*LATIN1)
File
"/home/jim/p/plone/buildout.coredev/src/Products.CMFPlone/Products/CMFPlone/tests/testUnicodeSplitter.py",
line 28, in _setlocale
str(LATIN1))
Error: ('Unsupported locale. These tests need at least one of the following
locales available on your system', "('en_US.ISO-8859-1',
'en_US.ISO8859-15', 'en_GB.ISO8859-15', 'de_DE@euro', 'fr_FR@euro',
'nl_NL@euro')")
1074/1143 (94.0%)
Error in test testProcessLatin1
(Products.CMFPlone.tests.testUnicodeSplitter.TestSplitter)
Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 329, in run
testMethod()
File
"/home/jim/p/plone/buildout.coredev/src/Products.CMFPlone/Products/CMFPlone/tests/testUnicodeSplitter.py",
line 89, in testProcessLatin1
saved = _setlocale(*LATIN1)
File
"/home/jim/p/plone/buildout.coredev/src/Products.CMFPlone/Products/CMFPlone/tests/testUnicodeSplitter.py",
line 28, in _setlocale
str(LATIN1))
Error: ('Unsupported locale. These tests need at least one of the following
locales available on your system', "('en_US.ISO-8859-1',
'en_US.ISO8859-15', 'en_GB.ISO8859-15', 'de_DE@euro', 'fr_FR@euro',
'nl_NL@euro')")
Gaaa, 2 errors that don't seem to show up in the summary. I'm guessing I
can fix these by installing some local in my container.
Oh, more of these above.
I also note a traceback with:
browser.open(portalURL+'/@@manage-dashboard?_authenticator=' +
createToken())
Is this trying to run a selenium test?
I don't see a failure in the output.
|
After adding a missing locale, I get no errors from bin/alltests in a linux container. |
@jimfulton thanks for testing this. It looks more like a problem or a difference in our Jenkins test setup. I hope we sort this out next week at Plone Open Garden in Sorrento/ Italy. |
d533783
to
97c8cb1
Compare
@jimfulton @jensens thanks for your effort, finally we could fix the weird errors on our jenkins setup. I removed all cached eggs on |
Woo hoo! |
Branch: refs/heads/master Date: 2022-09-20T16:13:29+02:00 Author: Laurent Lasudry (laulaz) <[email protected]> Commit: plone/plone.app.layout@1c9bfc5 Fix undefined logger variable Files changed: A news/323.bugfix M plone/app/layout/viewlets/social.py Repository: plone.app.layout Branch: refs/heads/master Date: 2022-09-20T16:13:47+02:00 Author: Laurent Lasudry (laulaz) <[email protected]> Commit: plone/plone.app.layout@5c921d2 Use a variable to allow customization of social tags image scale This refs #323 Files changed: A news/323.feature M plone/app/layout/viewlets/social.py Repository: plone.app.layout Branch: refs/heads/master Date: 2022-09-20T20:18:19+02:00 Author: Laurent Lasudry (laulaz) <[email protected]> Commit: plone/plone.app.layout@5a854bb Merge pull request #324 from plone/allow-social-image-scale-customization Use a variable to allow customization of the image scale used for social tags Files changed: A news/323.bugfix A news/323.feature M plone/app/layout/viewlets/social.py
Branch: refs/heads/2.1.x Date: 2024-02-27T10:23:53+01:00 Author: Peter Mathis (petschki) <[email protected]> Commit: plone/plone.staticresources@8a8d712 update `mockup=5.1.11` Files changed: M package.json Repository: plone.staticresources Branch: refs/heads/2.1.x Date: 2024-02-27T10:23:57+01:00 Author: Peter Mathis (petschki) <[email protected]> Commit: plone/plone.staticresources@0e77fa5 yarn install Files changed: M yarn.lock Repository: plone.staticresources Branch: refs/heads/2.1.x Date: 2024-02-27T10:24:02+01:00 Author: Peter Mathis (petschki) <[email protected]> Commit: plone/plone.staticresources@4a13b93 compile Files changed: A src/plone/staticresources/static/bundle-plone/chunks/43923.30b79421eba33766a6af.min.js A src/plone/staticresources/static/bundle-plone/chunks/43923.30b79421eba33766a6af.min.js.map M src/plone/staticresources/static/bundle-plone/bundle.min.js M src/plone/staticresources/static/bundle-plone/bundle.min.js.map M src/plone/staticresources/static/bundle-plone/remote.min.js M src/plone/staticresources/static/bundle-plone/remote.min.js.map D src/plone/staticresources/static/bundle-plone/chunks/43923.f779d09d898de12dcb6c.min.js D src/plone/staticresources/static/bundle-plone/chunks/43923.f779d09d898de12dcb6c.min.js.map Repository: plone.staticresources Branch: refs/heads/2.1.x Date: 2024-02-27T10:25:38+01:00 Author: Peter Mathis (petschki) <[email protected]> Commit: plone/plone.staticresources@8937035 changenote Files changed: A news/324.bugfix Repository: plone.staticresources Branch: refs/heads/2.1.x Date: 2024-02-27T11:35:14+01:00 Author: Peter Mathis (petschki) <[email protected]> Commit: plone/plone.staticresources@7ce772d Merge pull request #324 from plone/2.1.x-tinymce-image-fix Update `mockup=5.1.11` Files changed: A news/324.bugfix A src/plone/staticresources/static/bundle-plone/chunks/43923.30b79421eba33766a6af.min.js A src/plone/staticresources/static/bundle-plone/chunks/43923.30b79421eba33766a6af.min.js.map M package.json M src/plone/staticresources/static/bundle-plone/bundle.min.js M src/plone/staticresources/static/bundle-plone/bundle.min.js.map M src/plone/staticresources/static/bundle-plone/remote.min.js M src/plone/staticresources/static/bundle-plone/remote.min.js.map M yarn.lock D src/plone/staticresources/static/bundle-plone/chunks/43923.f779d09d898de12dcb6c.min.js D src/plone/staticresources/static/bundle-plone/chunks/43923.f779d09d898de12dcb6c.min.js.map
Branch: refs/heads/master Date: 2024-04-10T09:07:53+02:00 Author: 1letter (1letter) <[email protected]> Commit: plone/plone.app.upgrade@989969e sort imports via isort Files changed: M plone/app/upgrade/utils.py M plone/app/upgrade/v52/final.py M plone/app/upgrade/v60/tests.py Repository: plone.app.upgrade Branch: refs/heads/master Date: 2024-04-10T09:08:29+02:00 Author: 1letter (1letter) <[email protected]> Commit: plone/plone.app.upgrade@c3461cc add upgradestep for feature accordion plugin tinymce Files changed: A plone/app/upgrade/v61/alpha.py M plone/app/upgrade/v61/configure.zcml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2024-04-10T09:10:50+02:00 Author: 1letter (1letter) <[email protected]> Commit: plone/plone.app.upgrade@d4eb0aa add news Files changed: A news/324.feature Repository: plone.app.upgrade Branch: refs/heads/master Date: 2024-04-19T18:21:41+02:00 Author: Jens W. Klein (jensens) <[email protected]> Commit: plone/plone.app.upgrade@dccb372 Merge pull request #325 from plone/feature-#324 Feature #324 Files changed: A news/324.feature A plone/app/upgrade/v61/alpha.py M plone/app/upgrade/utils.py M plone/app/upgrade/v52/final.py M plone/app/upgrade/v60/tests.py M plone/app/upgrade/v61/configure.zcml
Branch: refs/heads/master Date: 2024-04-10T09:07:53+02:00 Author: 1letter (1letter) <[email protected]> Commit: plone/plone.app.upgrade@989969e sort imports via isort Files changed: M plone/app/upgrade/utils.py M plone/app/upgrade/v52/final.py M plone/app/upgrade/v60/tests.py Repository: plone.app.upgrade Branch: refs/heads/master Date: 2024-04-10T09:08:29+02:00 Author: 1letter (1letter) <[email protected]> Commit: plone/plone.app.upgrade@c3461cc add upgradestep for feature accordion plugin tinymce Files changed: A plone/app/upgrade/v61/alpha.py M plone/app/upgrade/v61/configure.zcml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2024-04-10T09:10:50+02:00 Author: 1letter (1letter) <[email protected]> Commit: plone/plone.app.upgrade@d4eb0aa add news Files changed: A news/324.feature Repository: plone.app.upgrade Branch: refs/heads/master Date: 2024-04-19T18:21:41+02:00 Author: Jens W. Klein (jensens) <[email protected]> Commit: plone/plone.app.upgrade@dccb372 Merge pull request #325 from plone/feature-#324 Feature #324 Files changed: A news/324.feature A plone/app/upgrade/v61/alpha.py M plone/app/upgrade/utils.py M plone/app/upgrade/v52/final.py M plone/app/upgrade/v60/tests.py M plone/app/upgrade/v61/configure.zcml
Original PR is #317. The second trial (#320) was to chaotic (I made wrong assumptions).
Now a third trial. I start with a simple cherry-pick of the original commit.