Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip 23.3.1 plus various small version updates. #896

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

mauritsvanrees
Copy link
Member

This pip version should be faster.
Some major version updates where a package dropped support for earlier Python versions.

This pip version should be faster.
Some major version updates where a package dropped support for earlier Python versions.
@mauritsvanrees
Copy link
Member Author

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member Author

The z3c.relationfield update from 1.0 to 1.1 breaks seven tests. All have the same source, a monkey patch from plone.app.relationfield. So maybe this monkey patch needs to be removed or adapted.
Sample error from the plone.app.relationfield tests themselves:

  File "/srv/python3.11/lib/python3.11/unittest/case.py", line 57, in testPartExecutor
    yield
  File "/srv/python3.11/lib/python3.11/unittest/case.py", line 623, in run
    self._callTestMethod(testMethod)
  File "/srv/python3.11/lib/python3.11/unittest/case.py", line 579, in _callTestMethod
    if method() is not None:
       ^^^^^^^^
  File "/home/jenkins/.buildout/eggs/cp311/plone.app.relationfield-3.0.3-py3.11.egg/plone/app/relationfield/tests/test_widget.py", line 52, in test_datamanager_set_nonempty
    self.assertEqual(dm.get(), self.person.addresses)
                     ^^^^^^^^
  File "/home/jenkins/.buildout/eggs/cp311/plone.app.relationfield-3.0.3-py3.11.egg/plone/app/relationfield/widget.py", line 164, in get
    if rel.isBroken():
       ^^^^^^^^^^^^^^
  File "/home/jenkins/.buildout/eggs/cp311/z3c.relationfield-1.1-py3.11.egg/z3c/relationfield/relation.py", line 105, in isBroken
    return self.to_id is None or self.from_object is None
                                 ^^^^^^^^^^^^^^^^
  File "/home/jenkins/.buildout/eggs/cp311/plone.app.relationfield-3.0.3-py3.11.egg/plone/app/relationfield/monkey.py", line 18, in get_from_object
    self._from_id = intids.register(self.__dict__["from_object"])
                                    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^

I will revert this part of the change for now, and open a separate issue.

Needs a fix in plone.app.relationfield first.
@mauritsvanrees
Copy link
Member Author

@jenkins-plone-org please run jobs

@gforcada gforcada merged commit f1b3669 into 6.0 Oct 25, 2023
@gforcada gforcada deleted the maurits-60-versions-update-20231025 branch October 25, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants