Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add old Plone 5 classes to the portlet template #417

Closed
wants to merge 1 commit into from
Closed

Conversation

thet
Copy link
Member

@thet thet commented Nov 26, 2024

Add Plone 5 classes portletHeader and portletContent to the portlet template to improve compatibility with Plone 5 styles.
This can help when migrating styles from Plone 5 to Plone 6.

Note: This targets only portlets yet. There is probably much more to do to improve the Plone 5 to 6 upgrade experience.

Add Plone 5 classes portletHeader and portletContent to the portlet template to
improve compatibility with Plone 5 styles.
This can help when migrating styles from Plone 5 to Plone 6.

Note: This targets only portlets yet. There is probably much more to do to
improve the Plone 5 to 6 upgrade experience.
@mister-roboto
Copy link

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@thet
Copy link
Member Author

thet commented Nov 28, 2024

@jenkins-plone-org please run jobs

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not my area of expertise.

I don't see these classes in the portlets in plone.app.portlets either.

Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two thoughts:

  1. I'm not sure if it really helps to mix possible "old" .plonePortlet CSS definitions with the .card utility. You have to put your hands on both scenarios either way.
  2. the portlet templates are spread over various packages so I'd wait for the template merge and add it afterwards (or during the merging)

@thet
Copy link
Member Author

thet commented Feb 28, 2025

I‌ had issues when upgrading a theme from Plone 5 to 6.
But I agree, there is a lot to adapt, let's go forward.

@thet thet closed this Feb 28, 2025
@thet thet deleted the plone5-classes branch February 28, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants