Skip to content

Commit

Permalink
Set constrain_package_deps to true in all tox envs.
Browse files Browse the repository at this point in the history
Without this, the tests fail because we get latest z3c.relationfield 1.1, even though latest Plone 6.1 pins 1.0.

Sample test failure:

```
Error in test test_relation_list_gets_translated (plone.app.multilingual.tests.test_lif.TestLanguageIndependentRelationField.test_relation_list_gets_translated)
Traceback (most recent call last):
  File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 57, in testPartExecutor
    yield
  File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 623, in run
    self._callTestMethod(testMethod)
  File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 579, in _callTestMethod
    if method() is not None:
  File "/Users/maurits/community/plone-coredev/6.1/src/plone.app.multilingual/src/plone/app/multilingual/tests/test_lif.py", line 222, in test_relation_list_gets_translated
    a_ca = api.translate(self.a_en, "ca")
  File "/Users/maurits/community/plone-coredev/6.1/src/plone.app.multilingual/src/plone/app/multilingual/api.py", line 46, in translate
    manager.add_translation(target_language)
  File "/Users/maurits/community/plone-coredev/6.1/src/plone.app.multilingual/src/plone/app/multilingual/manager.py", line 135, in add_translation
    translated_object = translation_factory(language)
  File "/Users/maurits/community/plone-coredev/6.1/src/plone.app.multilingual/src/plone/app/multilingual/factory.py", line 99, in __call__
    cloner(new_content)
  File "/Users/maurits/community/plone-coredev/6.1/src/plone.app.multilingual/src/plone/app/multilingual/dx/cloner.py", line 26, in __call__
    ILanguageIndependentFieldsManager(self.context).copy_fields(obj)
  File "/Users/maurits/community/plone-coredev/6.1/src/plone.app.multilingual/src/plone/app/multilingual/dx/cloner.py", line 78, in copy_fields
    copied_relation = self.copy_relation(
  File "/Users/maurits/community/plone-coredev/6.1/src/plone.app.multilingual/src/plone/app/multilingual/dx/cloner.py", line 42, in copy_relation
    if not relation_value or relation_value.isBroken():
  File "/Users/maurits/community/plone-coredev/6.1/src/plone.app.multilingual/.tox/test/lib/python3.11/site-packages/z3c/relationfield/relation.py", line 105, in isBroken
    return self.to_id is None or self.from_object is None
  File "/Users/maurits/community/plone-coredev/6.1/src/plone.app.multilingual/.tox/test/lib/python3.11/site-packages/plone/app/relationfield/monkey.py", line 18, in get_from_object
    self._from_id = intids.register(self.__dict__["from_object"])
KeyError: 'from_object'
```

For that KeyError, see plone/plone.app.relationfield#45.

But the issue that the current commit fixes, is that we should be using the proper constraints, instead of getting the latest from PyPI.
  • Loading branch information
mauritsvanrees committed Mar 11, 2024
1 parent 984b162 commit 0ab9b6d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .meta.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ dependencies_ignores = "['Products.LinguaPlone']"

[tox]
use_mxdev = true
constrain_package_deps = "true"
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ commands =
description = run the distribution tests
use_develop = true
skip_install = false
constrain_package_deps = false
constrain_package_deps = true
set_env =
ROBOT_BROWSER=headlesschrome

Expand Down Expand Up @@ -141,7 +141,7 @@ extras =
description = get a test coverage report
use_develop = true
skip_install = false
constrain_package_deps = false
constrain_package_deps = true
set_env =
ROBOT_BROWSER=headlesschrome

Expand Down

0 comments on commit 0ab9b6d

Please sign in to comment.