Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an upgrade step to update the dexterity indexer behavior name #301

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Sep 5, 2022

Renames collective.dexteritytextindexer to plone.textindexer

Fixes #300
Refs. plone/Products.CMFPlone#2780

Renames `collective.dexteritytextindexer` to `plone.textindexer`

Fixes #300
Refs. plone/Products.CMFPlone#2780
@ale-rt
Copy link
Member Author

ale-rt commented Sep 5, 2022

@jenkins-plone-org please run jobs

@ale-rt
Copy link
Member Author

ale-rt commented Sep 5, 2022

@plone/testing-team can you check the jenkins hooks?
I did not receive a message from mr.roboto and the magic comment does not trigger any job.

@ale-rt
Copy link
Member Author

ale-rt commented Sep 5, 2022

Note, I started the PR jobs on jenkins manually

@ale-rt
Copy link
Member Author

ale-rt commented Sep 7, 2022

@jenkins-plone-org please run jobs

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
But could you replace the interface as well?
collective.dexteritytextindexer.behavior.IDexterityTextIndexer

@mauritsvanrees
Copy link
Member

@ale-rt The Jenkins problems are being worked on.

@ale-rt
Copy link
Member Author

ale-rt commented Sep 8, 2022

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member

Jenkins for PRs is still broken, but local tests pass, at least bin/test -s plone.app.upgrade and bin/test -s Products.CMFPlone -m testMigrationTool. I will merge. The normal Jenkins jobs after merge should work fine.

@mauritsvanrees mauritsvanrees merged commit a11a44b into master Sep 8, 2022
@mauritsvanrees mauritsvanrees deleted the 300-bugfix branch September 8, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We do not have an upgrade path for collective.dexterityindexer
2 participants