Replace pkg_resources #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `importlib.metadata.distributions` instead.
36 tasks
This is needed for entry points.
In `example.ploneintegration`, the `example.addon` zcml gets loaded.
In `example.zopeintegration`, the `example.addon` and `example.multipleeps` zcml gets loaded.
This is because `example.{addon,multipleeps}/setup.py` has a strange entry point:
```
[z3c.autoinclude.plugin]
dummy = dummy
```
This was added to check if our code can handle unexpected entry point contents without breaking.
I don't really mind whether the zcml of these packages gets loaded or not, as this should not happen in practice.
But the new way of getting the available distributions and their entry points, apparently has this as side effect.
Pull Request Test Coverage Report for Build 13656371879Details
💛 - Coveralls |
mauritsvanrees
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Thanks for starting this. I have made a fix in commit 5876289: on Python 3.9 we really must use the entry_points from importlib_metadata, instead of the built in importlib.metadata.
And then the tests needed fixing because the new code finds a few more zcml files to load, but this should be fine.
|
Thanks for finishing the code! |
|
@jenkins-plone-org please run jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See plone/Products.CMFPlone#4126
Warning
tests are failing, if you remove the last commit, tests run fine, but there is
pkg_resourcesstill to be removed 🤷🏾