Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add portrait to toctree #1485

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Add portrait to toctree #1485

merged 2 commits into from
Sep 6, 2022

Conversation

stevepiercy
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 6, 2022 •
edited
Loading

✅ Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 3a1ad90
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/631708a554ef0d00097755f0

@mister-roboto
Copy link

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@stevepiercy stevepiercy added this to the Plone 6 Only milestone Sep 6, 2022
@stevepiercy stevepiercy self-assigned this Sep 6, 2022
@stevepiercy
Copy link
Contributor Author

@jenkins-plone-org please run jobs

@stevepiercy
Copy link
Contributor Author

I don't know what Jenkins is doing (or not doing), but it ain't passing. I don't think it matters for this tiny change.

@stevepiercy stevepiercy mentioned this pull request Sep 6, 2022
Closed
@stevepiercy
Copy link
Contributor Author

Jenkins is broken. We can ignore its failures for now. See plone/jenkins.plone.org#290

@sneridagh sneridagh merged commit 9dcd73d into master Sep 6, 2022
@sneridagh sneridagh deleted the add-portrait-to-toctree branch September 6, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneridagh sneridagh sneridagh approved these changes

@davisagli davisagli Awaiting requested review from davisagli

Assignees

@stevepiercy stevepiercy

Labels
None yet
Projects
Release Plone 6 docs
Status: Done
Milestone
Plone 6 Only
Development

Successfully merging this pull request may close these issues.
3 participants
@stevepiercy @mister-roboto @sneridagh