Fix for ZODB 5: Abort transaction before DB close. #30
Conversation
…rt transaction before DB close.
jensens
force-pushed
the
abort-before-close
branch
from
87c185e to
abfd70a
Compare
jensens
force-pushed
the
abort-before-close
branch
from
796fd9c to
45e3a13
Compare
|
Plone coredev uses plone.testing 4.3.x branch at the moment due to test isolation problems (those are caught by 5.0.x). |
src/plone/testing/z2.py
Outdated
| @@ -543,6 +543,8 @@ def setUpDatabase(self): | |||
| self['zodbDB'] = zodb.stackDemoStorage( | |||
| self.get('zodbDB'), | |||
| name='Startup') | |||
| import transaction | |||
There was a problem hiding this comment.
I think thin import can be moved to the top of the file.
There is already an import from OFS so I am quite sure that transaction will be available, too when this module is imported.
There was a problem hiding this comment.
Ok, I just followed the pattern used at other places in the file, I think hence this is not test code but test setup code import in the header is fine. I will change it and remove also the other occurrences.
src/plone/testing/z2.py
Outdated
| @@ -591,6 +593,8 @@ def tearDownDatabase(self): | |||
| del self._dbtab | |||
|
|
|||
| # Close and pop the zodbDB resource | |||
| import transaction | |||
src/plone/testing/z2.py
Outdated
| @@ -543,6 +543,8 @@ def setUpDatabase(self): | |||
| self['zodbDB'] = zodb.stackDemoStorage( | |||
| self.get('zodbDB'), | |||
| name='Startup') | |||
| import transaction | |||
| transaction.begin() | |||
There was a problem hiding this comment.
This will abort the current transaction if there was already one. I am not sure if this was intended.
There was a problem hiding this comment.
I was not sure about it and was not aware it could harm. I remove it.
jensens
force-pushed
the
abort-before-close
branch
from
45e3a13 to
e45e5f1
Compare
|
We are ready with this AFAICT. |
|
Do we really need |
|
@gforcada, if you ask me: No. But there are other opinions around stopping me from removing it. |
|
Then let's PLIP it :-) I would like to have some more consistency across the board |
|
@gforcada ok! do you take the initiative to write it? I second it and help were its needed. |
see plone/buildout.coredev#317 (comment)