-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct spelling errors and include omitted words in the documentation. #835
Conversation
I'm reading the Volto Hands-On documentation, and I've encountered some mistakes. I've raised a pull request to correct the errors. I, Vivek Kumar, agree to have this contribution published under the Creative Commons 4.0 International License (CC BY 4.0), with attribution to the Plone Foundation.
✅ Deploy Preview for plone-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Vivek-04022001 I noticed you inserted an extra word "the" that must be removed from the agreement statement in your description.
Sorry to be nitpicky. In the future, we suggest that you sign the Plone Contributor Agreement so you don't have to do this for every pull request. |
Co-authored-by: Steve Piercy <[email protected]>
Apologies, @stevepiercy. I'm familiar with MyST syntax because you provided details when I submitted my first pull request. This time, it was an accidental oversight on my part. I'll ensure not to write an entire paragraph in just one line in the future. I've already signed the Plone Agreement, but sometimes, I worry that my pull requests might not be accepted if I don't explicitly mention it in the description. However, moving forward, I won't include it with every pull request. Thank you for your feedback. |
@Vivek-04022001 thanks for the revision and update. Let's wait until you get that email notification, and then when you get it, would you please add a comment and |
@stevepiercy, I'm a bit confused about the instruction to "add a comment and @ to merge this PR." I have already received an email from Plone, which includes the PDF with all the necessary agreements mentioned. |
@Vivek-04022001 I don't see an email address on your agreement. From the last FAQ on https://plone.org/foundation/contributors-agreement:
I would suggest that you follow up to see what might have gone wrong. |
One more time, this time with feeling.
|
@stevepiercy, could you please verify my name? I received an email stating that I've been invited now. |
@Vivek-04022001 something is not right. Please make sure your emails on GitHub match what you put on the Agreement. If there is something else that does not align, then please contact [email protected]. |
Hello @stevepiercy, sorry to bother you, but could you please double-check my name? I just received another email confirming my invitation. |
@Vivek-04022001 thanks for the notice. It looks like it was corrected. Thank you for your patience and follow through. Merging. |
I'm reading the Volto Hands-On documentation, and I've encountered some mistakes. I've raised a pull request to correct the errors.
I, Vivek Kumar, agree to have this contribution published under the Creative Commons 4.0 International License (CC BY 4.0), with attribution to the Plone Foundation.