Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling errors and include omitted words in the documentation. #835

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

Vivek-04022001
Copy link
Member

I'm reading the Volto Hands-On documentation, and I've encountered some mistakes. I've raised a pull request to correct the errors.

I, Vivek Kumar, agree to have this contribution published under the Creative Commons 4.0 International License (CC BY 4.0), with attribution to the Plone Foundation.

I'm reading the Volto Hands-On documentation, and I've encountered some mistakes. I've raised a pull request to correct the errors.

I, Vivek Kumar, agree to have this contribution published under the Creative Commons 4.0 International License (CC BY 4.0), with attribution to the Plone Foundation.
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for plone-training ready!

Name Link
🔨 Latest commit 06523e3
🔍 Latest deploy log https://app.netlify.com/sites/plone-training/deploys/65bda75df66cf00008a5b77a
😎 Deploy Preview https://deploy-preview-835--plone-training.netlify.app/voltohandson/quickstart
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevepiercy
Copy link
Contributor

@Vivek-04022001 I noticed you inserted an extra word "the" that must be removed from the agreement statement in your description.

under the Creative Commons 4.0 International License

Sorry to be nitpicky. In the future, we suggest that you sign the Plone Contributor Agreement so you don't have to do this for every pull request.

docs/voltohandson/quickstart.md Outdated Show resolved Hide resolved
@Vivek-04022001
Copy link
Member Author

Apologies, @stevepiercy. I'm familiar with MyST syntax because you provided details when I submitted my first pull request. This time, it was an accidental oversight on my part. I'll ensure not to write an entire paragraph in just one line in the future.

I've already signed the Plone Agreement, but sometimes, I worry that my pull requests might not be accepted if I don't explicitly mention it in the description. However, moving forward, I won't include it with every pull request. Thank you for your feedback.

@stevepiercy
Copy link
Contributor

@Vivek-04022001 thanks for the revision and update. Let's wait until you get that email notification, and then when you get it, would you please add a comment and @ to merge this PR? It looks good, but that agreement piece is required. Thank you!

@Vivek-04022001
Copy link
Member Author

@stevepiercy, I'm a bit confused about the instruction to "add a comment and @ to merge this PR." I have already received an email from Plone, which includes the PDF with all the necessary agreements mentioned.
PLONE FOUNDATION contributor agreement Plone.pdf.

@stevepiercy
Copy link
Contributor

@Vivek-04022001 I don't see an email address on your agreement. From the last FAQ on https://plone.org/foundation/contributors-agreement:

I signed the Agreement, but haven't been given access yet?

Please allow a week for a response. Volunteers process the Contributor Agreements. If you have issues, such as making a spelling error in your email or GitHub username, please contact [email protected].

I would suggest that you follow up to see what might have gone wrong.

@Vivek-04022001
Copy link
Member Author

Screenshot 2024-01-26 015040
Is it necessary for me to compose an email and include my Gmail address in this agreement, even though my GitHub username is provided?

@stevepiercy
Copy link
Contributor

One more time, this time with feeling.

please contact [email protected].

@Vivek-04022001
Copy link
Member Author

@stevepiercy, could you please verify my name? I received an email stating that I've been invited now.

@stevepiercy
Copy link
Contributor

@Vivek-04022001 something is not right. Please make sure your emails on GitHub match what you put on the Agreement. If there is something else that does not align, then please contact [email protected].

@Vivek-04022001
Copy link
Member Author

Hello @stevepiercy, sorry to bother you, but could you please double-check my name? I just received another email confirming my invitation.

@stevepiercy
Copy link
Contributor

@Vivek-04022001 thanks for the notice. It looks like it was corrected. Thank you for your patience and follow through. Merging.

@stevepiercy stevepiercy merged commit 75d82f7 into plone:main Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants