Update deploy - add more explicit details to invoke and use make test command.md
#918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no hint for self students how to interpret the interactive output options of `make test` or how to detect missing results.
acsr
changed the title
make test command.md
I restructured the bits and pieces to flow better. This is training is focused on deployment, not on how to interpret test results beyond pass or fail. So I removed the expected hints statement. Please take a look, and let me know if it looks good to you.
stevepiercy
approved these changes
Jan 28, 2025
|
@acsr I restructured the bits and pieces to flow better. This training is focused on deployment, not on how to interpret test results beyond pass or fail. So I removed the expected hints statement. Please take a look, and let me know if it looks good to you. Thank you for contributing! |
|
@stevepiercy Thanks for the overhaul and clarifying the scope of the test result mentioned. Go for it! |
stevepiercy
deleted the
acsr-patch-training-deploy-building-docker-images-make-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no hint for self students how to interpret the interactive output options of
make testor how to detect missing results.Also the switching of the context in terminal is not explicitly mentioned. So I suggest two more lines how to switch back and forth. The context can be guessed by the path of the makefile, but this can be overseen.
Remark: This is also my first test for the Quick & Dirty
Suggest Editworkflow from the docs UI.