Add conditional variations support #5424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tiberiuichim
approved these changes
Nov 22, 2023
davisagli
reviewed
Nov 22, 2023
|
@tiberiuichim I had to change the order of execution of the withVariationSchemaEnhancer HOC, so first it adds the field, then it enhances it. It's done only for the variations. Do you think it's needed also for the other extensions? Let me know, please. I will add documentation for this on Monday. |
tiberiuichim
approved these changes
Dec 4, 2023
|
@robgietema Waiting for the docs you said you were going to push... |
stevepiercy
requested changes
Dec 5, 2023
davisagli
force-pushed
the
conditionalVariationsSupport
branch
2 times, most recently
from
016c722 to
4eb2dd3
Compare
stevepiercy
requested changes
Dec 6, 2023
davisagli
force-pushed
the
conditionalVariationsSupport
branch
from
1ef8ce3 to
7d6c784
Compare
|
@sneridagh @robgietema Since I rebased on |
|
@sneridagh @robgietema ok, found it |
davisagli
requested changes
Dec 6, 2023
davisagli
force-pushed
the
conditionalVariationsSupport
branch
from
24589eb to
01a915d
Compare
davisagli
approved these changes
Dec 6, 2023
davisagli
added a commit
that referenced
this pull request
Dec 7, 2023
Co-authored-by: Rob Gietema <[email protected]> Co-authored-by: David Glick <[email protected]>
davisagli
added a commit
that referenced
this pull request
Dec 7, 2023
Co-authored-by: Rob Gietema <[email protected]> Co-authored-by: David Glick <[email protected]>
pranayjoshi
pushed a commit
to pranayjoshi/volto
that referenced
this pull request
Dec 20, 2023
Co-authored-by: Rob Gietema <[email protected]> Co-authored-by: David Glick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.