Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify pylintrc and always run black #2755

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Feb 9, 2024

In #2735 unsupported python versions were dropped, so only one pylint config is needed and black can always run.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • unify pylintrc
    • always run black
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@graingert graingert force-pushed the 3-12-followup-fixes branch from 9849a2c to 951bf46 Compare February 9, 2024 11:10
@graingert graingert marked this pull request as ready for review February 9, 2024 12:25
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Much nicer, thanks! Rerunning the failed test now...

@alexcjohnson alexcjohnson merged commit 6b31a8f into plotly:dev Feb 15, 2024
3 checks passed
@graingert graingert deleted the 3-12-followup-fixes branch February 15, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants