Removed calls to unwrap() and expect() #35
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #33
This removes most calls to
.unwrap()
and.expect()
except in example and test code as well as a handful of cases where we're guaranteed not to fail. Methods that were affected have had their signatures changed to returnResult<T, Error>
.I implemented error types with thiserror so it's easy to wrangle together the different kinds of sub-errors that can occur under a common type. A downside here is it's more difficult to annotate certain common failures (like std::io::Error) with custom messages in certain places. It might be worth investigating using snafu in the future to assign contexts to errors, but for now there should be enough information in the errors themselves to describe the different points of failure.