Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the group assigned on ticket creation to history #265

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ArthurMinfotel
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.

Description

Use hook item_add to create first record in glpi_plugin_escalade_histories when a group is assigned at creation.
Related to issues 261.

@stonebuzz
Copy link
Contributor

Hi @ArthurMinfotel

can you resolve conflicts?

@stonebuzz
Copy link
Contributor

And add unit tests ?

@ArthurMinfotel
Copy link
Contributor Author

ArthurMinfotel commented Jan 21, 2025

And add unit tests ?

I've added a test which check :

  1. Was the history properly created if the ticket is created with a group assigned.
  2. Was the first group assigned removed if the ticket is updated with 2 groups assigned (the one assigned in 1 and a new one).
  3. Was the change of group assigned which happenned during 2 properly recorded in the history.

@stonebuzz stonebuzz requested a review from Rom1-B January 23, 2025 08:11
@stonebuzz
Copy link
Contributor

Hi Arthur, I have my doubts about this PR's commits

this one :

image

Is already in core

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants