Skip to content

Commit

Permalink
Merge pull request FEX-Emu#3867 from pmatos/NoDisableTests
Browse files Browse the repository at this point in the history
Remove Disabled_Tests file
  • Loading branch information
Sonicadvance1 authored Jul 15, 2024
2 parents b8e864f + ed87c01 commit e65545a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 58 deletions.
6 changes: 3 additions & 3 deletions Scripts/guest_test_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def LoadTestsFileResults(File):
for i in range(len(sys.argv) - StartingFEXArgsOffset):
RunnerArgs.append(sys.argv[StartingFEXArgsOffset + i])

#print(RunnerArgs)
# print(RunnerArgs)

ResultCode = 0

Expand All @@ -130,7 +130,8 @@ def LoadTestsFileResults(File):
TryCount = 5

if (disabled_tests.get(test_name)):
ResultCode = -73
print(f"Test {test_name} is disabled")
sys.exit(0)

# expect zero by default
if (not test_name in expected_output):
Expand Down Expand Up @@ -170,4 +171,3 @@ def LoadTestsFileResults(File):
else:
# passed and expected to pass -- pass the test
sys.exit(0)

45 changes: 2 additions & 43 deletions unittests/gcc-target-tests-64/Disabled_Tests
Original file line number Diff line number Diff line change
@@ -1,45 +1,4 @@
# This has invalid asm generated for its test
# 'foo' gets the argument in edi
# Passes the argument to bar in eax
# 'bar' accepts the argument in edi
# inline asm is incorrect, needs to use =d and d on the value
asm-5.c.gcc-target-test-64

# Fails even on host device
# 'test_pextrw' does a zero extend to the gpr
# Which means its -3339 value turns in to 0xf2f5
# While the 'compute_correct_result' value does a sign extension
# Which turns the value in to 0xfffff2f5
# This causes its comparison to fail
sse2-mmx-pextrw.c.gcc-target-test-64

# Uses AVX
# Test is compiled with -march=native, which means the build machine had avx
# Needs to be recompiled to care about it
pr57275.c.gcc-target-test-64

# Fails even on host device
# Stores a large 64bit value in to a union of double and 'unsigned long long'
# 'test' loads this value in to a x87 register, then stores that value on to the stack
# Checks the flag and skips a bunch of x87 logic, and loads that value back from the stack in to rax
# Value has been munged from the fld + fstp step
# 0xFFF279535D540FE4 was the original value
# 0xFFFA79535D540FE4 was the value it turned in to
pr88240.c.gcc-target-test-64

# This relies on SIGPROF which means we need real signal support to handle this
# Crashes or hangs depending on which runner is running it
mcount_pic.c.gcc-target-test-64

# These tests fail because of things unrelated to the sse4.1 instructions
sse4_1-ceil-sfix-vec.c.gcc-target-test-64
sse4_1-ceilf-sfix-vec.c.gcc-target-test-64
sse4_1-floor-sfix-vec.c.gcc-target-test-64
sse4_1-floorf-sfix-vec.c.gcc-target-test-64
sse4_1-rint-sfix-vec.c.gcc-target-test-64
sse4_1-rintf-sfix-vec.c.gcc-target-test-64
sse4_1-round-sfix-vec.c.gcc-target-test-64
sse4_1-roundf-sfix-vec.c.gcc-target-test-64

# This has a race with SIGPROF
# Crashes or hangs depending on which runner is running it.
# Also this has a race with SIGPROF
mcount_pic.c.gcc-target-test-64
12 changes: 0 additions & 12 deletions unittests/gcc-target-tests-64/Known_Failures
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ asm-5.c.gcc-target-test-64
# This causes its comparison to fail
sse2-mmx-pextrw.c.gcc-target-test-64

# Uses AVX
# Test is compiled with -march=native, which means the build machine had avx
# Needs to be recompiled to care about it
pr57275.c.gcc-target-test-64

# Fails even on host device
# Stores a large 64bit value in to a union of double and 'unsigned long long'
# 'test' loads this value in to a x87 register, then stores that value on to the stack
Expand All @@ -27,10 +22,6 @@ pr57275.c.gcc-target-test-64
# 0xFFFA79535D540FE4 was the value it turned in to
pr88240.c.gcc-target-test-64

# This relies on SIGPROF which means we need real signal support to handle this
# Crashes or hangs depending on which runner is running it
mcount_pic.c.gcc-target-test-64

# These tests fail because of things unrelated to the sse4.1 instructions
sse4_1-ceil-sfix-vec.c.gcc-target-test-64
sse4_1-ceilf-sfix-vec.c.gcc-target-test-64
Expand All @@ -40,6 +31,3 @@ sse4_1-rint-sfix-vec.c.gcc-target-test-64
sse4_1-rintf-sfix-vec.c.gcc-target-test-64
sse4_1-round-sfix-vec.c.gcc-target-test-64
sse4_1-roundf-sfix-vec.c.gcc-target-test-64

# This has a race with SIGPROF
mcount_pic.c.gcc-target-test-64

0 comments on commit e65545a

Please sign in to comment.