ndctl/lib/libndctl.c, add read dirty_shutdown info in function popula… #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te_cxl_dimm_attributes() First, dirty_shutdown info is an essential info and must not be defaut value when calling PMDK create-namespace command; Sencond, it is necessary to read basic dimm info from sysfs in regardless of keep it with defaut value, which is always negative and result in error in application Note that PMDK use at link: https://github.com/pmem/pmdk/blob/master/src/libpmem2/usc_ndctl.c : int pmem2_source_device_usc()->ndctl_dimm_get_dirty_shutdown()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ndctl/lib/libndctl.c: add read dirty_shutdown info in populate_cxl_dimm_attributes()
First, dirty_shutdown info is an essential info and must not be defaut value when calling PMDK create-namespace command; Sencond, it is necessary to read basic dimm info from sysfs in regardless of keep it with defaut value, which is always negative and result in error in application
Note that PMDK use at link: https://github.com/pmem/pmdk/blob/master/src/libpmem2/usc_ndctl.c : int pmem2_source_device_usc()->ndctl_dimm_get_dirty_shutdown()