Remove dead code #40
Remove dead code #40
Conversation
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)
README.md, line 2 at r1 (raw file):
# pmemkv-tools Optional tools and utilities for pmemkv
update pls
|
perhaps, if any of this iteration/baseline scripts may be useful we should file an issue in this repo to port it (someday) to proper repo(s). |
|
README.md, line 2 at r1 (raw file): Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
I was thinking of it, but probably this should be updated as part of name change. |
|
Any really useful part is storage_efficiency, which was implemented only for ruby - so we may port it there. I mentioned in pmem/pmemkv-java#99, we need such test also in java. |
karczex
force-pushed
the
remove_dead_code
branch
from
22ade9f
to
dee9d72
Compare
|
README.md, line 2 at r1 (raw file): Previously, karczex (Paweł Karczewski) wrote…
I didn't noticed, the name changed in meantime. |
|
README.md, line 2 at r1 (raw file): Previously, karczex (Paweł Karczewski) wrote…
Done. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @karczex)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)
a discussion (no related file):
hmm.. perhaps update also gitignore file
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @karczex)
README.md, line 76 at r3 (raw file):
export LD_LIBRARY_PATH=</path/to/libpmemkv.so.1>
that might be a bit misleading - it's not path to the libpmemkv.so but a path to directory in which libpmemkv.so is located
* Bindings code is not compatible nor tested with stable releases. Measurements should be implemented and tested (at least to check building) in each binding repository separately.
karczex
force-pushed
the
remove_dead_code
branch
from
dee9d72
to
0b7ac2b
Compare
There was a problem hiding this comment.
Reviewable status: 11 of 13 files reviewed, 2 unresolved discussions (waiting on @igchor and @lukaszstolarczuk)
a discussion (no related file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
hmm.. perhaps update also gitignore file
Done.
README.md, line 76 at r3 (raw file):
Previously, igchor (Igor Chorążewicz) wrote…
that might be a bit misleading - it's not path to the libpmemkv.so but a path to directory in which libpmemkv.so is located
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @igchor and @karczex)
README.md, line 74 at r4 (raw file):
If pmemkv is installed in some non-standard path, `LD_LIBRARY_PATH` variable should be set to the directory which contain `libpmemkv.so.1` file
contains
karczex
force-pushed
the
remove_dead_code
branch
from
0b7ac2b
to
fa7e2fd
Compare
There was a problem hiding this comment.
Reviewable status: 12 of 13 files reviewed, 2 unresolved discussions (waiting on @igchor and @lukaszstolarczuk)
README.md, line 74 at r4 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
contains
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)
There was a problem hiding this comment.
Reviewable status:
This change is