Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

utils: make sure hub command is available #947

Conversation

lukaszstolarczuk
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk commented Feb 22, 2021

when preparing PR with docs.
It may fail in some near future, since hub package is out of Fedora Rawhide distribution (see: pmem/libpmemobj-cpp#1013 )


This change is Reviewable

Copy link

@karczex karczex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)


utils/docker/run-doc-update.sh, line 55 at r1 (raw file):

git config --local user.name ${BOT_NAME}
git config --local user.email "${BOT_NAME}@intel.com"
hub config --global hub.protocol https

this change is probably not needed, as you are using hub command before check in line 99, which will fail just after clone anyway.

@lukaszstolarczuk
Copy link
Member Author

quite curious, I've missed that, thanks!

@lukaszstolarczuk lukaszstolarczuk deleted the check-for-hub-in-auto-docs-script branch February 22, 2021 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants