Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

[tests] add async cases for timestamp test #274

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KFilipek
Copy link
Contributor

@KFilipek KFilipek commented Oct 19, 2022

Added asynchronous cases for timestamp test.

Issues related:
Resolves #275
Resolves #211


This change is Reviewable

Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @KFilipek)

a discussion (no related file):
please rebase with the latest master



tests/unittest/timestamp.cpp line 4 at r1 (raw file):

/* Copyright 2022, Intel Corporation */

#include <random>

do we need this?

Copy link
Contributor Author

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @KFilipek and @lukaszstolarczuk)

a discussion (no related file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

please rebase with the latest master

Done.



tests/unittest/timestamp.cpp line 4 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

do we need this?

Line 28: there is Mersenne twister for std::shuffle() function.
Done.

Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KFilipek)

@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft December 2, 2022 11:35
@lukaszstolarczuk
Copy link
Member

For this PR to be merged we'd have to fix the reported issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants