Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnderPearls now teleports to the correct world #6450

Draft
wants to merge 2 commits into
base: minor-next
Choose a base branch
from

Conversation

dadodasyra
Copy link

Introduction

EnderPearls currently teleports the player where it landed in the player world when the projectile hit something.
Normal behaviour should be that player is teleported to the coordinates AND the world of the ender pearl.

Changes

API changes

None

Behavioural changes

None except what's written in introduction.

Backwards compatibility

Should not be a thing.

Follow-up

This may be completed by a system to avoid teleporting player after it's death.

I tested this PR by doing the following (tick all that apply):

  • Writing PHPUnit tests (commit these in the tests/phpunit folder)
  • Playtesting using a Minecraft client (provide screenshots or a video)
  • Writing a test plugin (provide the code and sample output)
  • Other (This was written in PhpStorm, no syntax issues, CIs runs well and there's no reason that it broke something.)

@dktapps
Copy link
Member

dktapps commented Sep 11, 2024

I think it would make more sense to not teleport the player if they are in a different world. Can't really think of a reason why anyone would want to be teleported back to the world they just left.

@dktapps
Copy link
Member

dktapps commented Sep 11, 2024

Really this ought to be locked behind a teleport counter and is generally a bigger problem than multiworld. See #3397 (comment)

Copy link
Member

@dktapps dktapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New behaviour doesn't make much sense. See comments on #3397 (comment) and related issues.

@dadodasyra
Copy link
Author

After some singleplayer vanilla testing it seems that :

  • The ender pearl teleport is cancelled between dimensions
  • Death doesn't change anything to the current thrown ender pearls. If the player dies and respawn fast enough he's still teleported.

Will take a look at it when I have the time. For the time I move to a draft

@dadodasyra dadodasyra marked this pull request as draft September 11, 2024 21:36
@dktapps
Copy link
Member

dktapps commented Sep 12, 2024

What vanilla does is irrelevant. The expected behaviour should be the behaviour that makes the most sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants