-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: useTexture callback parameter and behavior #1970
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@jwueller Can you please resolve merge conflicts and merge |
@FarazzShaikh the conflicts resolution is the only blocker? |
@clementroche yes. But the conflicts are extensive. Better to start a new PR with latest upstream |
omw @FarazzShaikh |
done in #2142 @FarazzShaikh |
why another PR for solving conflicts? is this one to be considered as outdated/duplicate now? |
@abernier Yes, this one is duplicate now and should be closed. The last time I checked, there were a lot of conflicts as this PR was made before the refactor. |
Why
Fixes #1968
Fixes #1969
What
Fixes the behavior of the
useTexture(..., onLoad)
callback according to the declared types, as well as the conditions under which it is fired (i.e. when the data changes, not when the function does).Checklist
No documentation or storybook change is required, because this just fixes previously-documented behavior.