Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useTexture callback parameter and behavior #1970

Closed
wants to merge 1 commit into from

Conversation

jwueller
Copy link

Why

Fixes #1968
Fixes #1969

What

Fixes the behavior of the useTexture(..., onLoad) callback according to the declared types, as well as the conditions under which it is fired (i.e. when the data changes, not when the function does).

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

No documentation or storybook change is required, because this just fixes previously-documented behavior.

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 6:35pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@FarazzShaikh
Copy link
Member

@jwueller Can you please resolve merge conflicts and merge master into this? There was a refactor to Drei. Please let me know if youre not able to, we will close this and reopen a new PR on latest master

@FarazzShaikh FarazzShaikh requested review from FarazzShaikh and removed request for FarazzShaikh September 25, 2024 16:51
@FarazzShaikh FarazzShaikh self-assigned this Sep 25, 2024
@clementroche
Copy link
Contributor

clementroche commented Oct 29, 2024

@FarazzShaikh the conflicts resolution is the only blocker?

@FarazzShaikh
Copy link
Member

@clementroche yes. But the conflicts are extensive. Better to start a new PR with latest upstream

@clementroche
Copy link
Contributor

omw @FarazzShaikh

@clementroche
Copy link
Contributor

clementroche commented Oct 29, 2024

done in #2142 @FarazzShaikh

@abernier
Copy link
Member

abernier commented Oct 29, 2024

why another PR for solving conflicts? is this one to be considered as outdated/duplicate now?

@FarazzShaikh
Copy link
Member

@abernier Yes, this one is duplicate now and should be closed. The last time I checked, there were a lot of conflicts as this PR was made before the refactor.

@abernier
Copy link
Member

abernier commented Oct 29, 2024

@abernier Yes, this one is duplicate now and should be closed. The last time I checked, there were a lot of conflicts as this PR was made before the refactor.

ok, closing as duplicates in favor of #2142

@abernier abernier closed this Oct 29, 2024
@abernier abernier added the duplicate This issue or pull request already exists label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
4 participants