Deprecate ABT_{thread/task}_{retain/release} #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABT_DEPRECATED is an attribute for a deprecated function.
ABT_thread_retain(), ABT_thread_release(), ABT_task_retain(), ABT_task_release() have been designed to control refcounts of threads and tasks. These functions have the following issues: 1. Currently, they are broken (i.e., ABT_thread_release() does not free a thread even if the counter becomes 0). 2. Fixing it is costly since this adds atomic refcount operations on freeing threads (i.e., ABT_thread_free()). 3. These functions are not used in our understanding. At least, they do not appear in our tests. This patch deprecates these functions. If there's no complaint, they are removed in the future release.
|
test:jenkins/all |
2 similar comments
|
test:jenkins/all |
|
test:jenkins/all |
|
These functions are marked as deprecated, but they are not removed immediately; please let us know if these functions are actually used. |
This was referenced Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #17,
ABT_thread_retain(),ABT_thread_release(),ABT_task_retain(), andABT_task_release(), which have been designed to control refcounts of threads and tasks, have the following issues:ABT_thread_release()does not free a thread even if the counter becomes 0).ABT_thread_free()).This PR deprecates these functions. If there's no complaint, they will be removed in the future release.
Note that this patch does not break the current release/retain mechanism; it will just warn programmers:
Note:
ax_gcc_func_attribute.m4does not have a license issue and is used in MPICH, for example.https://github.com/pmodels/mpich/blob/master/confdb/ax_gcc_func_attribute.m4