pool: Add a unit test for the old pool API #368
Conversation
This API is still used by some users according to issue pmodels#355 so we want to make sure it is still tested. Change-Id: I29b9c3726a738d78936028249f9c3f96e7216416
|
The added test passes, however there are some warnings cause I am currently using the new API for creating the pool def struct. I'm not sure how to create the pool def struct using the old API. |
| } | ||
| } | ||
|
|
||
| ABT_pool create_pool(ABT_pool_config config) |
There was a problem hiding this comment.
The following must be updated (previously, function pointers are directly set to ABT_pool_def). See https://github.com/pmodels/argobots/blob/v1.1/examples/scheduling/sched_and_pool_user.c#L277-L320
Note that ABT_pool_user_def == ABT_pool_def * for backward compatibility (see #354).
|
@epmikida Thank you for your contribution! Please use the old API to check the old pool behavior. The following is an example (note: the latest example uses the new API): https://github.com/pmodels/argobots/blob/v1.1/examples/scheduling/sched_and_pool_user.c Please feel free to ask me any questions. |
|
Note: I relaxed the GitHub Action restriction, so the basic CI checks should run automatically when you push/rebase commits to your local branch registered to this PR. |
This API is still used by some users according to issue so we want to make sure it is still tested.
See #355.