Skip to content

Commit

Permalink
prov/cxi: Remove srx unittests
Browse files Browse the repository at this point in the history
The cxi provider shared RX unittests verify that the cxi provider
returns -FI_ENOSYS. With linkx support, this is not the case. Remove
these now invalid tests.

Signed-off-by: Ian Ziemba <[email protected]>
  • Loading branch information
iziemba committed Oct 29, 2024
1 parent f71668a commit 871da0f
Showing 1 changed file with 0 additions and 58 deletions.
58 changes: 0 additions & 58 deletions prov/cxi/test/ep.c
Original file line number Diff line number Diff line change
Expand Up @@ -295,17 +295,6 @@ Test(ep, ep_bind_stx_ctx)
"TODO Add test for STX CTXs binding to the endpoint when implemented");
}

Test(ep, ep_bind_srx_ctx)
{
int ret;
struct fi_rx_attr *attr = NULL;
void *context = NULL;

ret = fi_srx_context(cxit_domain, attr, NULL, context);
cr_assert_eq(ret, -FI_ENOSYS,
"TODO Add test for SRX CTXs binding to the endpoint when implemented");
}

Test(ep, ep_bind_unhandled)
{
int ret;
Expand Down Expand Up @@ -970,53 +959,6 @@ Test(ep, stx_ctx)
cr_assert_eq(ret, FI_SUCCESS, "fi_close stx_ep. %d", ret);
}

Test(ep, srx_ctx_null_srx)
{
int ret;
struct fi_rx_attr *attr = NULL;
void *context = NULL;

ret = fi_srx_context(cxit_domain, attr, NULL, context);
/* TODO Fix when fi_srx_context is implemented, should be -FI_EINVAL */
cr_assert_eq(ret, -FI_ENOSYS, "fi_srx_context null srx. %d", ret);
}

Test(ep, srx_ctx)
{
int ret;
struct fi_rx_attr *attr = NULL;
struct fid_ep *srx;
struct cxip_ep *srx_ep;
void *context = &ret;
struct cxip_domain *dom;
struct cxip_rxc *rxc;
int refs;

dom = container_of(cxit_domain, struct cxip_domain,
util_domain.domain_fid);
refs = ofi_atomic_get32(&dom->ref);

ret = fi_srx_context(cxit_domain, attr, &srx, context);
/* TODO Fix when fi_srx_context is implemented, should be FI_SUCCESS */
cr_assert_eq(ret, -FI_ENOSYS, "fi_stx_context failed. %d", ret);
if (ret == -FI_ENOSYS)
return;

srx_ep = container_of(srx, struct cxip_ep, ep);
rxc = srx_ep->ep_obj->rxc;

/* Validate stx */
cr_assert_eq(rxc->domain, dom);
cr_assert_eq(ofi_atomic_inc32(&dom->ref), refs + 1);
cr_assert_eq(srx_ep->ep.fid.fclass, FI_CLASS_RX_CTX);
cr_assert_eq(srx_ep->ep.fid.context, context);
cr_assert_eq(rxc->state, RXC_ENABLED);
cr_assert_eq(rxc->min_multi_recv, CXIP_EP_MIN_MULTI_RECV);

ret = fi_close(&srx->fid);
cr_assert_eq(ret, FI_SUCCESS, "fi_close srx_ep. %d", ret);
}

TestSuite(ep_init, .timeout = CXIT_DEFAULT_TIMEOUT);

Test(ep_init, auth_key)
Expand Down

0 comments on commit 871da0f

Please sign in to comment.