Adds "aad administrativeunit member list" command #5652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @MartinM85, we'll review asap! |
martinlingstuyl
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Hi @MartinM85, Great work! Let's do a round of cleaning up before we merge this.
docs/docs/cmd/aad/administrativeunit/administrativeunit-member-list.mdx
Outdated
Show resolved
Hide resolved
src/m365/aad/commands/administrativeunit/administrativeunit-member-list.ts
Show resolved
Hide resolved
src/m365/aad/commands/administrativeunit/administrativeunit-member-list.ts
Show resolved
Hide resolved
martinlingstuyl
requested changes
Dec 9, 2023
There was a problem hiding this comment.
Hi @MartinM85, almost done. I've got a couple of remarks left. I'll be able to merge it next week if you do the changes first.
docs/docs/cmd/aad/administrativeunit/administrativeunit-member-list.mdx
Outdated
Show resolved
Hide resolved
src/m365/aad/commands/administrativeunit/administrativeunit-member-list.spec.ts
Outdated
Show resolved
Hide resolved
docs/docs/cmd/aad/administrativeunit/administrativeunit-member-list.mdx
Outdated
Show resolved
Hide resolved
src/m365/aad/commands/administrativeunit/administrativeunit-member-list.ts
Outdated
Show resolved
Hide resolved
src/m365/aad/commands/administrativeunit/administrativeunit-member-list.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # docs/src/config/sidebars.ts
martinlingstuyl
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Great work @MartinM85, I'll merge it soon with some cosmetic changes.
|
Merged manually, thanks! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5640