Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated option username from entra m365group user set, Closes #6224 #6274

Closed
wants to merge 2 commits into from
Closed

Remove deprecated option username from entra m365group user set, Closes #6224 #6274

wants to merge 2 commits into from

Conversation

nicodecleyre
Copy link
Contributor

There are 2 examples in the doc file about a single user. I was not sure whether to keep it and change it to the new used option usernames, or to remove them. I opted to go for the first situation. Let me know if you opt for the 2nd situation

Closes #6224

@milanholemans
Copy link
Contributor

Thank you @nicodecleyre! We'll try to review ASAP.
Updating the examples is indeed the right option to do.

@milanholemans milanholemans added the pr-major PR for the next major release label Aug 26, 2024
@milanholemans milanholemans changed the base branch from main to v9 August 26, 2024 21:54
@MathijsVerbeeck
Copy link
Contributor

@nicodecleyre This is a V9 pr. Could you please include a small upgrade guidance?

@MathijsVerbeeck MathijsVerbeeck self-assigned this Aug 26, 2024
@nicodecleyre
Copy link
Contributor Author

@nicodecleyre This is a V9 pr. Could you please include a small upgrade guidance?

Will do!

@Adam-it
Copy link
Contributor

Adam-it commented Aug 30, 2024

Due to an upcoming breaking change connected to CLI for Microsoft 365 login experience we will need to do a v9 release a bit sooner than we anticipated. Due to that we had to change the target of this PR to v10 which will be the next regular major release.

@MathijsVerbeeck MathijsVerbeeck marked this pull request as draft September 1, 2024 11:20
@MathijsVerbeeck
Copy link
Contributor

@nicodecleyre Not wanting to rush you, but we are planning to release the v10 end of october. If you don't mind, can you please try and create the upgrade guidance ASAP?

Thanks!

@Adam-it Adam-it changed the base branch from v10 to main September 30, 2024 13:29
@nicodecleyre nicodecleyre force-pushed the Remove-options-username-from-entra-m365group-user-set branch from 5f83a7f to e7f5fe4 Compare October 2, 2024 21:23
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review October 4, 2024 08:27
MathijsVerbeeck
MathijsVerbeeck approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@MathijsVerbeeck MathijsVerbeeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just one minor comment which I will fix when merging.

docs/docs/v10-upgrade-guidance.mdx Show resolved Hide resolved
@nicodecleyre
Copy link
Contributor Author

Great job, just one minor comment which I will fix when merging.

Thank you! 🙏

@MathijsVerbeeck
Copy link
Contributor

Thanks for this contribution @nicodecleyre .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathijsVerbeeck MathijsVerbeeck MathijsVerbeeck approved these changes

Assignees

@MathijsVerbeeck MathijsVerbeeck

Labels
pr-major PR for the next major release pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated option username from entra m365group user set
4 participants
@nicodecleyre @milanholemans @MathijsVerbeeck @Adam-it