Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes "entra m365group set" command. Closes #6061 #6384

Closed
wants to merge 3 commits into from
Closed

Fixes "entra m365group set" command. Closes #6061 #6384

wants to merge 3 commits into from

Conversation

nanddeepn
Copy link
Contributor

Fixes entra m365group set command. Closes #6061

Modified the functionality so that all existing owners/members are removed from the group, and the specified users are added.

@milanholemans
Copy link
Contributor

Thank you @nanddeepn, we'll try to review it ASAP!

@milanholemans milanholemans added the pr-major PR for the next major release label Sep 24, 2024
@milanholemans milanholemans changed the base branch from main to v10 September 24, 2024 19:12
@milanholemans
Copy link
Contributor

@nanddeepn seems like you have some merge conflicts with v10, could you rebase please?

@nanddeepn
Copy link
Contributor Author

Thank you @milanholemans
Resolved the conflicts.

@Adam-it Adam-it changed the base branch from v10 to main September 30, 2024 13:28
@milanholemans
Copy link
Contributor

Hi @nanddeepn could you rebase with the latest main for the last time? Since v10 is merged with main, it shouldn't get out of sync anymore.

@milanholemans milanholemans marked this pull request as draft October 2, 2024 08:40
@nanddeepn nanddeepn marked this pull request as ready for review October 2, 2024 10:47
@nanddeepn
Copy link
Contributor Author

Done @milanholemans

@milanholemans
Copy link
Contributor

Hi @nanddeepn seems like the rebase didn't really work.

@milanholemans
Copy link
Contributor

Hi @nanddeepn, I've rebased your PR with the latest main in the meantime so we can get this in ASAP. Note that you should pull these changes on your local branch, or remove your branch locally and pull it again.

@martinlingstuyl martinlingstuyl self-assigned this Oct 4, 2024
martinlingstuyl
martinlingstuyl requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nanddeepn, nice work! I do have some comments. Could you look at them and get back to me? let me know if you have any questions!

docs/docs/cmd/entra/m365group/m365group-set.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/entra/m365group/m365group-set.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/entra/m365group/m365group-set.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/entra/m365group/m365group-set.mdx Outdated Show resolved Hide resolved
src/m365/entra/commands/m365group/m365group-set.ts Show resolved Hide resolved
src/m365/entra/commands/m365group/m365group-set.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/m365group/m365group-set.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/m365group/m365group-set.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/m365group/m365group-set.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/m365group/m365group-set.ts Show resolved Hide resolved
@nanddeepn
Copy link
Contributor Author

Hi @martinlingstuyl
The review comments are implemented.

@martinlingstuyl
Copy link
Contributor

Merged manually, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl approved these changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
pr-major PR for the next major release pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change functionality of entra m365group set when specifying users
3 participants
@nanddeepn @milanholemans @martinlingstuyl