Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Command pp website webfile get #6424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ktskumar
Copy link
Contributor

Closes #6273

Added new command pp website webfile get

@milanholemans
Copy link
Contributor

Hi @ktskumar thank you for creating yet another PR, we're truly grateful for that.
However, I've noticed that you are creating new commands using our old approach. For about 2 months, we switched the structure for commands. Since then, we have required all new commands to implement ZOD instead of using the old approach with option interfaces. Please, keep in mind next time that new commands should use a ZOD scheme.
You can find some examples at: login, flow recyclebinitem list, flow recyclebinitem restore, spo site get, spo site sharingpermission set, ...

@Adam-it Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Oct 29, 2024

@ktskumar I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: m365 pp website webfile get
3 participants