-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command: entra roledefinition add. Closes #6466 #6521
base: main
Are you sure you want to change the base?
New command: entra roledefinition add. Closes #6466 #6521
Conversation
Thanks @MartinM85, we'll try to review it ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @MartinM85. A couple of comments before we merge this...
src/m365/entra/commands/roledefinition/roledefinition-add.spec.ts
Outdated
Show resolved
Hide resolved
src/m365/entra/commands/roledefinition/roledefinition-add.spec.ts
Outdated
Show resolved
Hide resolved
|
||
The following resource actions (permissions) can be assigned to a custom Entra ID role definition: | ||
|
||
|Permission|Description| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list is really quite long. Plus it can change, which means our docs would not be up to date.
I'll discuss this with the maintainers what we should do with this.
Do you know if there's a graph endpoint that returns these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might create a new command for that, to help people creating a new role definition. That would mean we don't have to paste the list in the docs..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resources actions can be retrieved through the https://graph.microsoft.com/v1.0/roleManagement/directory/resourceNamespaces/microsoft.directory/resourceActions
, but not all resource actions can be assigned to a custom role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new command for retrieving resource actions would be useful
Closes #6466