Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: entra roledefinition add. Closes #6466 #6521

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MartinM85
Copy link
Contributor

Closes #6466

@Jwaegebaert
Copy link
Contributor

Thanks @MartinM85, we'll try to review it ASAP.

@martinlingstuyl martinlingstuyl self-assigned this Jan 9, 2025
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @MartinM85. A couple of comments before we merge this...

@martinlingstuyl martinlingstuyl marked this pull request as draft January 9, 2025 20:55
@MartinM85 MartinM85 marked this pull request as ready for review January 10, 2025 06:56

The following resource actions (permissions) can be assigned to a custom Entra ID role definition:

|Permission|Description|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list is really quite long. Plus it can change, which means our docs would not be up to date.
I'll discuss this with the maintainers what we should do with this.

Do you know if there's a graph endpoint that returns these?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might create a new command for that, to help people creating a new role definition. That would mean we don't have to paste the list in the docs..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resources actions can be retrieved through the https://graph.microsoft.com/v1.0/roleManagement/directory/resourceNamespaces/microsoft.directory/resourceActions, but not all resource actions can be assigned to a custom role

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new command for retrieving resource actions would be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: entra roledefinition add
3 participants