Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command : tenant report settings set - closes #6247 #6548

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NishkalankBezawada
Copy link

New command : tenant report settings set - closes #6247

Explanation

This command can be used to update (adminReportSettings) tenant-level settings for Microsoft 365 reports.
Please refer to the Graph documentation page.

Usage

m365 tenant report settings set [options]

test screens

Below has set --hideUserInformation to false
image

below is the screen from the Admin center

image

Below has set --hideUserInformation to true

image

below is the screen from the Admin center

image

Thanks,
Nish

@milanholemans
Copy link
Contributor

Thanks @NishkalankBezawada, we'll try to review it ASAP.

@martinlingstuyl
Copy link
Contributor

Hi @NishkalankBezawada, I ran the tests that we usually do on PR's. There's a couple of issue though, or so it appears. Could you like at them and fix them in your code? You may want to run npm run test afterwards, to ensure the tests are running OK on your machine.

Let me know if you have questions.

@martinlingstuyl martinlingstuyl marked this pull request as draft January 10, 2025 14:29
@martinlingstuyl martinlingstuyl self-assigned this Jan 10, 2025
@NishkalankBezawada
Copy link
Author

Hi @NishkalankBezawada, I ran the tests that we usually do on PR's. There's a couple of issue though, or so it appears. Could you like at them and fix them in your code? You may want to run npm run test afterwards, to ensure the tests are running OK on your machine.

Let me know if you have questions.

Hey @martinlingstuyl

Thanks for reviewing. Since this is my first contribution to the repository, I might have missed a few things. I will surely check on this in the evening, and send in for your review.

Thanks,
Nish

@martinlingstuyl
Copy link
Contributor

Yes it's me 😄!

You can always check our contribution documentation, which is quite good. Also when it's about unit tests.
https://pnp.github.io/cli-microsoft365/contribute/contributing-guide

If you've got any questions, let me know 🚀

@NishkalankBezawada
Copy link
Author

Yes it's me 😄!

You can always check our contribution documentation, which is quite good. Also when it's about unit tests. https://pnp.github.io/cli-microsoft365/contribute/contributing-guide

If you've got any questions, let me know 🚀

Hey @martinlingstuyl, This pretty much helped me.

Will be sending a new review soon 🚀

Thanks,
Nish

@NishkalankBezawada NishkalankBezawada marked this pull request as ready for review January 11, 2025 18:19
@NishkalankBezawada
Copy link
Author

Hey @martinlingstuyl

Can you review it once again.

Thanks,
Nish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: tenant report settings set
3 participants