Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 'spo folder roleassignment add' command. Closes #6555 #6557

Closed
wants to merge 2 commits into from
Closed

Fixes 'spo folder roleassignment add' command. Closes #6555 #6557

wants to merge 2 commits into from

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented Jan 9, 2025

Closes #6555

@martinlingstuyl martinlingstuyl self-assigned this Jan 9, 2025
@martinlingstuyl
Copy link
Contributor

Superb @Adam-it! Will review and merge soon

martinlingstuyl
martinlingstuyl requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @Adam-it, just one comment!

src/m365/spo/commands/folder/folder-roleassignment-add.ts Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft January 9, 2025 07:51
@Adam-it Adam-it marked this pull request as ready for review January 9, 2025 08:58
@Adam-it
Copy link
Member Author

Adam-it commented Jan 9, 2025

@martinlingstuyl I did the clean up in the tests as well

martinlingstuyl
martinlingstuyl reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I'll merge it soon...

martinlingstuyl
martinlingstuyl approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@martinlingstuyl
Copy link
Contributor

Merged, thanks for being awesome! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl approved these changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
pr-bugfix pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug report: spo folder roleassignment add command will also break role inheritance
2 participants
@Adam-it @martinlingstuyl