Rebuild bot implementation - Solves #237 & #246 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 25, 2021
wictorwilen
requested changes
Oct 26, 2021
packages/generator-teams/src/app/templates/src/server/server.ts
Outdated
Show resolved
Hide resolved
packages/generator-teams/src/bot/templates/src/server/{botName}/dialogs/mainDialog.ts
Show resolved
Hide resolved
packages/generator-teams/src/bot/templates/src/server/{botName}/dialogs/mainDialog.ts
Show resolved
Hide resolved
|
Thanks for the comments, I added my thoughts. In any case I'd like to make all tests green as well as changing the obvious things you mentioned before we continue 👍🏻 |
packages/generator-teams/src/bot/templates/src/server/{botName}/dialogs/helpDialog.ts
Outdated
Show resolved
Hide resolved
wictorwilen
requested changes
Nov 4, 2021
|
Let me work on that asap so that linting issues are resolved |
|
Linting errors should be all fixed now, so we are good to go I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebuilt the bot implementation so that it aligns more with the official botbuilder samples and it allows devs to extend it with their dialogs quite easily.
Additionally, we can use this new template to add SSO functionality in the future as well, with little effort.
It should solve #237 and #246