Skip to content

Commit

Permalink
Merge branch 'version-3' into version-3
Browse files Browse the repository at this point in the history
  • Loading branch information
juliemturner authored Sep 14, 2023
2 parents bef55e2 + 47e1d37 commit a543bf8
Show file tree
Hide file tree
Showing 12 changed files with 231 additions and 630 deletions.
88 changes: 88 additions & 0 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,91 @@ body:
required: true


=======
name: 🐞 Bug or Error Report
description: Submit a bug or error report.
labels: ["type: something isn't working", "status: investigate"]

body:
- type: markdown
attributes:
value: |
This issue type is for submitting bugs or errors you believe you have found with the PnPjs library. If your submission references permission errors or 5xx status code responses, this is almost certainly not a bug with PnPjs but rather and issue with your configuration, please refer to other support options listed on the [new issue chooser page](https://github.dev/juliemturner/pnpjs/issues/new/choose). Please provide as much information as possible so we can best address your submission. Thanks!
- Follow our guidance on [How To Create Good Issues](https://github.dev/juliemturner/pnpjs/wiki/How-to-Create-Good-Issues).
- Remember to include sufficient details and context.
- If you have multiple questions, suggestions, or bugs, please submit them in separate issues.
- type: dropdown
attributes:
label: Major Version
options:
- 4.x
- 3.x
- 2.x (No longer supported)
- 1.x (No longer supported)
validations:
required: true
- type: input
id: minorver
attributes:
label: Minor Version Number
description: Include the minor and patch version numbers, e.g. for 4.1.0
placeholder: '1.0'
validations:
required: true
- type: dropdown
attributes:
label: Target environment
options:
- All
- SharePoint Framework
- NodeJS
- Browser App (Hosted external to Microsoft 365 platform)
- other (enter in the "Additional environment details" area below)
validations:
required: true
- type: textarea
attributes:
label: Additional environment details
description: Please describe the environment you're working in and how you're authenticating.
placeholder: |
I'm using NodeJS and certificate based MSAL for authentication.
validations:
required: true
- type: textarea
attributes:
label: Expected or Desired Behavior
description: Describe what you are trying to accomplish.
placeholder: |
I'm trying to get items from a list in a site.
validations:
required: true
- type: textarea
attributes:
label: Observed Behavior
description: Describe the results you're getting.
placeholder: |
I'm getting an empty response
validations:
required: true
- type: textarea
attributes:
label: Steps to Reproduce
description: Please included code fenced example code, OR a link to a code snippet using GitHub or CodePen or the like to show how your code is structured. See the sample above.
placeholder: |
Here is the code I'm running
```TypeScript
import { spfi } from "@pnp/sp";
import "@pnp/sp/webs";
import "@pnp/sp/lists";
import "@pnp/sp/items";
const sp = spfi(...);
// get all the items from a list
const items: any[] = await sp.web.lists.getByTitle("My List").items();
console.log(items);
```
validations:
required: true
50 changes: 50 additions & 0 deletions .github/ISSUE_TEMPLATE/enhancement.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,56 @@ name: 🏗 Enhancement
description: Suggest an enhancement
labels: ["type: enhancement", "status: investigate"]

body:
- type: markdown
attributes:
value: |
This issue type is for suggesting or discussing enhancements to the library.
- Follow our guidance on [How To Create Good Issues](https://github.dev/juliemturner/pnpjs/wiki/How-to-Create-Good-Issues).
- Remember to include sufficient details and context.
- If you have multiple questions, suggestions, or bugs, please submit them in separate issues.
- type: dropdown
attributes:
label: Target environment
options:
- All
- SharePoint Framework
- NodeJS
- Browser App (Hosted external to Microsoft 365 platform)
- other (enter in the "Additional environment details" area below)
validations:
required: false
- type: textarea
attributes:
label: Additional environment details
description: Please describe the environment you're working in and how you're authenticating.
placeholder: |
I'm using NodeJS and certificate based MSAL for authentication.
- type: textarea
attributes:
label: Enhancement Idea
description: Please included details to describe your situation, code fenced example code OR a link to a code snippet using GitHub or CodePen or the like to show how your code is structured and get you the right help more quickly.
placeholder: |
I'm struggling to get a list item. Here is the code I'm running. Can anyone help me figure out what's wrong?
```TypeScript
import { spfi } from "@pnp/sp";
import "@pnp/sp/webs";
import "@pnp/sp/lists";
import "@pnp/sp/items";
const sp = spfi(...);
// get all the items from a list
const items: any[] = await sp.web.lists.getByTitle("My List").items();
console.log(items);
```
=======
name: 🏗 Enhancement
description: Suggest an enhancement
labels: ["type: enhancement", "status: investigate"]

body:
- type: markdown
attributes:
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/question.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,4 @@ body:
console.log(items);
```
validations:
required: true
required: true
Loading

0 comments on commit a543bf8

Please sign in to comment.