Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re: Use @azure/msal-browser instead of MSAL #2832

Closed
wants to merge 3 commits into from
Closed

Re: Use @azure/msal-browser instead of MSAL #2832

wants to merge 3 commits into from

Conversation

datyin
Copy link

@datyin datyin commented Nov 18, 2023

Category

  • Bug fix?
  • New feature?
  • New sample?
  • Documentation update?

Related Issues

Since MSAL is deprecated now, we should use @azure/msal-browser

What's in this Pull Request?

Refactored MSAL behavior

@datyin
Copy link
Author

datyin commented Nov 18, 2023

I've resubmitted it for Version 4 :)

@bcameron1231 bcameron1231 self-requested a review November 20, 2023 15:15
@bcameron1231
Copy link
Collaborator

I'll review this. Thanks!

@bcameron1231 bcameron1231 added this to the 4.0.0 milestone Nov 30, 2023
Updating missing update in docs
Adjusting serve\main.ts debugging sample.
@bcameron1231
Copy link
Collaborator

Updated some missing docs, fixed eslint error. Tests appear to run locally just fine.

@patrick-rodgers / @juliemturner Any additional testing you'd like to do before merging?

juliemturner added a commit that referenced this pull request Jan 12, 2024
@juliemturner
Copy link
Collaborator

Fixed merge conflicts and pulling with PR #2900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants