Node Clone - Fix #2903
Merged
Node Clone - Fix #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge. I'm submitting this PR as a potential fix and leaving it here for discussing and seeing if this is a viable option for handling our rawData events. |
bcameron1231
force-pushed
the
fix-2890
branch
from
68ccba6
to
6e7b94a
Compare
bcameron1231
force-pushed
the
fix-2890
branch
from
6e7b94a
to
440303e
Compare
Removing emit of rawData from queryable and instead moving it into the parser. This would allow us to handle the recommended fix for larger responses in node. Also allows to remove unnecessary clone from BlobParse. Update caching.ts Update parsers.ts Update parsers.ts Update parsers.ts
bcameron1231
force-pushed
the
fix-2890
branch
from
440303e
to
fa8934f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing emit of rawData from queryable and instead moving it into the parser. This would allow us to handle the recommended fix for larger responses in node. Also allows to remove unnecessary clone from BlobParse.
Category
Related Issues
fixes #2890
What's in this Pull Request?
A potential fix for the node response.clone() issue. Using Node's recommendation for handling larger responses https://github.com/node-fetch/node-fetch?tab=readme-ov-file#custom-highwatermark I've removed our existing logic for rawData off from queryable and into our default parser.
This would allow parsers and our rawdata to be handled in parallel and avoiding the current issue of cloning large responses in Node.