Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1862 #1872

Conversation

NishkalankBezawada
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1862

What's in this Pull Request?

Fixing issue 1862 - Dynamic form should hide fields that are hidden on the List Content Type

Issue

When a form on a library with content types is rendered, and some fields are hidden at list content type level, those fields are still shown on the form. This is still on the latest release v3.19.0 as below,

image

Solution

A simple check as below,

      // Process fields that are not marked as hidden
      if (hiddenFields.indexOf(field.InternalName) < 0) {
        if(field.Hidden === false) { *** added new condition 
        *** other logic here***
        }

Making field.Hidden === false resolves the issue as below,

image

Guidance

@martinlingstuyl

Thanks,
Nishkalank Bezawada

@joaojmendes joaojmendes self-assigned this Oct 18, 2024
@joaojmendes joaojmendes added this to the 3.20.0 milestone Oct 18, 2024
@joaojmendes joaojmendes added the status:fixed-next-drop Issue will be fixed in upcoming release. label Oct 18, 2024
@joaojmendes
Copy link
Collaborator

@NishkalankBezawada Thank you for the fix

@joaojmendes joaojmendes merged commit dd9a259 into pnp:dev Oct 18, 2024
1 check passed
@NishkalankBezawada
Copy link
Contributor Author

@NishkalankBezawada Thank you for the fix

Pleasure is mine 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants