Updated and corrected for SPFX 1.20 upgrade

pnp · Oct 24, 2024 · 7b1e001 · 7b1e001
1 parent a45efa3
commit 7b1e001
Show file tree

Hide file tree

Showing 9 changed files with 1,770 additions and 4,243 deletions.
diff --git a/samples/react-application-collab-footer/.yo-rc.json b/samples/react-application-collab-footer/.yo-rc.json
@@ -2,12 +2,12 @@
   "@microsoft/generator-sharepoint": {
     "plusBeta": false,
     "isCreatingSolution": true,
-    "nodeVersion": "16.19.0",
+    "nodeVersion": "18.18.2",
     "sdksVersions": {
       "@microsoft/microsoft-graph-client": "3.0.2",
-      "@microsoft/teams-js": "2.4.1"
+      "@microsoft/teams-js": "2.24.0"
     },
-    "version": "1.16.1",
+    "version": "1.20.0",
     "environment": "spo",
     "libraryName": "react-application-collab-footer",
     "libraryId": "8b5fa72c-26f0-488a-a952-6ec68c81f623",

diff --git a/samples/react-application-collab-footer/README.md b/samples/react-application-collab-footer/README.md
@@ -60,7 +60,7 @@ Version|Date|Comments
 1.0|May 9, 2018|Initial release
 2.0|January 1, 2020|Initial release for SharePoint Starter Kit v2
 3.0|February 2023|v3 - Upgraded to SPFx 1.16.1
-4.0|October 2024 | Updated the code to SPFX 1.20.1, Refactored the project to react 17, went over to graph api, cleaned up the code etc etc.
+4.0|October 2024 | Updated the code to SPFX 1.20, Refactored the project to react 17, Node 18, went over to graph api, cleaned up the code etc etc.
 
 
 
@@ -82,7 +82,9 @@ Version|Date|Comments
 * Move to correct folder where solution exists
 * in the command line run:
   * `npm install`
-  * `gulp serve`
+  * `gulp serve --nobrowser`
+  * `Add to the end of the URL test on your site : ?debugManifestsFile=https://localhost:4321/temp/manifests.js&loadSPFX=true&customActions={"6638da67-06f4-4f55-a1df-485d568e8b72":{"location":"ClientSideExtension.ApplicationCustomizer","properties":{"sourceTermSet":"PnP-CollabFooter-SharedLinks","linksListTitle":"PnP-PortalFooter-Links","personalItemsStorageProperty":"PnP-CollabFooter-MyLinks"}}}`
+
 
 ## Features
 

diff --git a/samples/react-application-collab-footer/config/config.json b/samples/react-application-collab-footer/config/config.json
@@ -14,7 +14,6 @@
   "externals": {},
   "localizedResources": {
     "CollaborationFooterApplicationCustomizerStrings": "lib/extensions/collaborationFooter/loc/{locale}.js",
-    "MyLinksStrings": "lib/extensions/collaborationFooter/components/myLinks/loc/{locale}.js",
-    "ControlStrings": "node_modules/@pnp/spfx-controls-react/lib/loc/{locale}.js"
+    "MyLinksStrings": "lib/extensions/collaborationFooter/components/myLinks/loc/{locale}.js"
   }
 }
diff --git a/samples/react-application-collab-footer/config/serve.json b/samples/react-application-collab-footer/config/serve.json
@@ -2,30 +2,5 @@
   "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/spfx-serve.schema.json",
   "port": 4321,
   "https": true,
-  "serveConfigurations": {
-    "default": {
-      "pageUrl": "https://avarante.sharepoint.com/SitePages/home.aspx",
-      "customActions": {
-        "6638da67-06f4-4f55-a1df-485d568e8b72": {
-          "location": "ClientSideExtension.ApplicationCustomizer",
-          "properties": {
-            "sourceTermSet": "PnP-CollabFooter-SharedLinks",
-            "personalItemsStorageProperty": "PnP-CollabFooter-MyLinks"
-          }
-        }
-      }
-    },
-    "collaborationFooter": {
-      "pageUrl": "https://avarante.sharepoint.com/SitePages/home.aspx",
-      "customActions": {
-        "6638da67-06f4-4f55-a1df-485d568e8b72": {
-          "location": "ClientSideExtension.ApplicationCustomizer",
-          "properties": {
-            "sourceTermSet": "PnP-CollabFooter-SharedLinks",
-            "personalItemsStorageProperty": "PnP-CollabFooter-MyLinks"
-          }
-        }
-      }
-    }
-  }
+  "initialPage": "https://{tenantDomain}/_layouts/workbench.aspx"
 }