React application collab footer - Updated! #1434
Conversation
…ect to be more modern and use react 17 features, cleaned up the code, more logging etc etc
NicolasKheirallah
changed the title
There was a problem hiding this comment.
I am not sure the approach we did here is correct. I don't think we should move the solution outside of starter kit repo but instead open a PR in that repo to update it there. I will double check it with @hugoabernier and @VesaJuvonen before we proceed but I will label this PR as hacktoberfest-accepted so that it will count towards your hacktoberfest challenge already
Either works for me :) I'm currently working on bringing the starter-kit to 1.20! |
|
@NicolasKheirallah let's leave this PR as draft until I will know how we should proceed on this and should we leave it here or update it in the starter kit. I will keep you updated |
|
@NicolasKheirallah I rechecked this with Vesa and Hugo and we agreed that it is ok to move this updated solution to this repo so we may proceed. |
There was a problem hiding this comment.
@NicolasKheirallah Awesome work so far 👏👏👏
I managed to build and tested the solution
I noticed a few things we should correct before we merge this. Please do give them a double check 🙏
|
|
||
| ## Used SharePoint Framework Version | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
we should update this to SPFx 1.20.0
| ## Todo | ||
| - [ ] Add Graph Support! | ||
| - [ ] Clean up the code | ||
| - [ ] Add support for icons for my links | ||
| - [ ] Add support for sorting my links |
There was a problem hiding this comment.
is this something which was present in the starter kit readme and moved here or was it something we added? ether way seems more like notes to me than information which should be part of readme. Lets remove this
There was a problem hiding this comment.
I added it but we can remove it! :) It's more of a note what changes I want to implement!
|
|
||
| <img src="https://m365-visitor-stats.azurewebsites.net/sp-dev-fx-extensions/samples/react-application-collab-footer" /> | ||
| <img src="https://telemetry.sharepointpnp.com/sp-starter-kit/source/react-application-collab-footer" /> |
There was a problem hiding this comment.
we should not update this url as it is used for counting telemetry of how many users visited the sample in this repo
|
|
||
| This application customizer provides you the ability to include a footer designed for normal and group associated teams sites. The footer includes sets of links configured using the tenant wide deployment list at the app catalog. A second set of links are personalized links, unqiue to each user, stored within each user's user profile within a user profile property. If this property does not exist in the user profile service, this capability will be hidden. | ||
|  |
There was a problem hiding this comment.
seems we should also move the assets image from starter kit and update the path here so that it will be also present here
Co-authored-by: Adam Wójcik <[email protected]>
Co-authored-by: Adam Wójcik <[email protected]>
What's in this Pull Request?
Updated the code and clean the code, update it to SPFX 1.20 and the code to be more up to date and modern! Still need to find a better way to handle taxonomy links, as navigation isn't supported by graph. So I kept the old style of getting data for taxonomy and User profile to keep it uniformly