Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React teams tabs graph #5364

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

NicolasKheirallah
Copy link
Contributor

  • New sample
  • Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
A new sample based on another sample: react-teams-tabs-pnpjs, code was refactored and rewritten to Graph API, more modern code, error handling and added functionality.
Created sample seperatly as original one is written with PnPJS for those who want to use that (I will update that project to!)

written for:

  • SPFX 1.20
  • React 17
  • FluentUI

Node Version

Node version used: V18.18.2

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • [] My solution includes a .nvmrc file indicating the version of Node.js

Copy link

github-actions bot commented Jan 2, 2025

Validation failed!

File: samples/react-teams-tabs-graph/assets/sample.json

@hugoabernier hugoabernier merged commit a7d9c79 into pnp:main Jan 13, 2025
1 check failed
Copy link

Validation failed!

File: samples/react-teams-tabs-graph/assets/sample.json

Copy link

Validation failed!

File: samples/react-teams-tabs-graph/assets/sample.json

@hugoabernier
Copy link
Collaborator

Thanks @NicolasKheirallah for your update! Highly appreciated!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants