Put double quotes around rm command args #633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if `$PNPM_HOME` or `$(pnpm store path)` expand to values with a space character, then `rm` will treat it as two different arguments and try and delete them both. Depending on where the space is, it could delete something bad. But putting double quotes around it, we prevent that.
|
|
|
@ccouzens is attempting to deploy a commit to the pnpm Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
$PNPM_HOMEor$(pnpm store path)expand to values with a space character, then the shell will treat it as two different arguments forrmto delete.Depending on where the space is, it could delete something bad.
But putting double quotes around it, we prevent that, and the shell will always treat is as a single argument