-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed plot bugs, added functionality, updated images #353
Merged
+466
−134
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0ffa67b
Added plot.utils functions and updated map images
ventsiR c93f6f4
fixed bug with awpy.plot not handling lower level points (for maps li…
ventsiR 2c2d2f9
Fixed vary_alpha argument for plot.heatmap() not working
ventsiR 2072762
Added optional argument to not plot points out of bounds of map image
ventsiR 06fe374
Minor changes; renaming vars, adjusting function args
ventsiR 60a89af
Renaming
ventsiR 1bdb424
Linting fixes
ventsiR 0ac6d02
linting fixes
ventsiR f2917f8
Merge branch '2.0.0b5' into main
ventsiR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed vary_alpha argument for plot.heatmap() not working
vary_alpha functionality of plot.heatmap() was not working correctly because values were set to np.nan before applying alpha arithmetic. I also added vary_alpha_range as an argument for users to set min and max alpha for each point
commit 2c2d2f9d57533816212364b77edf9e34503f15a5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unclear as to what this parameter is doing -- do you mind explaining again? I realize I don't quite remember what I wrote 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously (before I added
vary_alpha_range
) whenvary_alpha
was set toTrue
, it would plot the densest points with alpha equal to thealpha
argument, the least dense points withalpha = 0
, and anything in between would be assigned linearly between0
andalpha
.vary_alpha_range
lets the user set a custom range (instead of0
andalpha
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now realize that
vary_alpha_range
might be a confusing name - it was intended to sound like "the range of argumentvary_alpha
", but it sounds like, "vary the alpha's range".Can't think of anything better though - I considered
alpha_range
, but it's even more ambiguous :DThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. If an alpha range is specified, should we assume the user wants to vary_alpha? This may allow us to remove one arg. If so, then I think having
alpha_range
is a fine name, as long you add just a tiny bit more explanation in the docstring!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!