fix(Data): fixed warnings about missing copy ctors in Data::Time and …

…Data::Date.

Data/include/Poco/Data/Date.h

@@ -31,7 +31,7 @@ namespace Dynamic {
 
 class Var;
 
-}
+} // namespace Dynamic
 
 namespace Data {
 
@@ -56,6 +56,9 @@ class Data_API Date
 	~Date();
 		/// Destroys the Date.
 
+	Date(const Date & ) = default;
+	Date(Date && ) = default;
+
 	int year() const;
 		/// Returns the year.
 
@@ -151,7 +154,8 @@ inline bool Date::operator > (const Date& date) const
 }
 
 
-} } // namespace Poco::Data
+} // namespace Data
+} // namespace Poco
 
 
 //
@@ -171,39 +175,38 @@ class VarHolderImpl<Poco::Data::Date>: public VarHolder
 	{
 	}
 
-	~VarHolderImpl()
-	{
-	}
+	~VarHolderImpl() = default;
+	VarHolderImpl() = delete;
 
-	const std::type_info& type() const
+	const std::type_info& type() const override
 	{
 		return typeid(Poco::Data::Date);
 	}
 
-	void convert(Poco::Timestamp& val) const
+	void convert(Poco::Timestamp& val) const override
 	{
 		DateTime dt;
 		dt.assign(_val.year(), _val.month(), _val.day());
 		val = dt.timestamp();
 	}
 
-	void convert(Poco::DateTime& val) const
+	void convert(Poco::DateTime& val) const override
 	{
 		val.assign(_val.year(), _val.month(), _val.day());
 	}
 
-	void convert(Poco::LocalDateTime& val) const
+	void convert(Poco::LocalDateTime& val) const override
 	{
 		val.assign(_val.year(), _val.month(), _val.day());
 	}
 
-	void convert(std::string& val) const
+	void convert(std::string& val) const override
 	{
-		DateTime dt(_val.year(), _val.month(), _val.day());
+		const DateTime dt(_val.year(), _val.month(), _val.day());
 		val = DateTimeFormatter::format(dt, "%Y/%m/%d");
 	}
 
-	VarHolder* clone(Placeholder<VarHolder>* pVarHolder = 0) const
+	VarHolder* clone(Placeholder<VarHolder>* pVarHolder = nullptr) const override
 	{
 		return cloneHolder(pVarHolder, _val);
 	}
@@ -214,12 +217,12 @@ class VarHolderImpl<Poco::Data::Date>: public VarHolder
 	}
 
 private:
-	VarHolderImpl();
 	Poco::Data::Date _val;
 };
 
 
-} } // namespace Poco::Dynamic
+} // namespace Dynamic
+} // namespace Poco
 
 
 #endif // Data_Date_INCLUDED

Data/include/Poco/Data/Time.h

@@ -29,7 +29,7 @@ namespace Dynamic {
 
 class Var;
 
-}
+} // namespace Dynamic
 
 class DateTime;
 
@@ -56,6 +56,9 @@ class Data_API Time
 	~Time();
 		/// Destroys the Time.
 
+	Time(const Time & ) = default;
+	Time(Time && ) = default;
+
 	int hour() const;
 		/// Returns the hour.
 
@@ -151,7 +154,8 @@ inline bool Time::operator > (const Time& time) const
 }
 
 
-} } // namespace Poco::Data
+} // namespace Data
+} // namespace Poco
 
 
 //
@@ -171,43 +175,42 @@ class VarHolderImpl<Poco::Data::Time>: public VarHolder
 	{
 	}
 
-	~VarHolderImpl()
-	{
-	}
+	~VarHolderImpl() override = default;
+	VarHolderImpl() = delete;
 
-	const std::type_info& type() const
+	const std::type_info& type() const override
 	{
 		return typeid(Poco::Data::Time);
 	}
 
-	void convert(Poco::Timestamp& val) const
+	void convert(Poco::Timestamp& val) const override
 	{
 		Poco::DateTime dt;
 		dt.assign(dt.year(), dt.month(), dt.day(), _val.hour(), _val.minute(), _val.second());
 		val = dt.timestamp();
 	}
 
-	void convert(Poco::DateTime& val) const
+	void convert(Poco::DateTime& val) const override
 	{
 		Poco::DateTime dt;
 		dt.assign(dt.year(), dt.month(), dt.day(), _val.hour(), _val.minute(), _val.second());
 		val = dt;
 	}
 
-	void convert(Poco::LocalDateTime& val) const
+	void convert(Poco::LocalDateTime& val) const override
 	{
 		Poco::LocalDateTime ldt;
 		ldt.assign(ldt.year(), ldt.month(), ldt.day(), _val.hour(), _val.minute(), _val.second());
 		val = ldt;
 	}
 
-	void convert(std::string& val) const
+	void convert(std::string& val) const override
 	{
-		DateTime dt(0, 1, 1, _val.hour(), _val.minute(), _val.second());
+		const DateTime dt(0, 1, 1, _val.hour(), _val.minute(), _val.second());
 		val = DateTimeFormatter::format(dt, "%H:%M:%S");
 	}
 
-	VarHolder* clone(Placeholder<VarHolder>* pVarHolder = 0) const
+	VarHolder* clone(Placeholder<VarHolder>* pVarHolder = nullptr) const override
 	{
 		return cloneHolder(pVarHolder, _val);
 	}
@@ -218,7 +221,6 @@ class VarHolderImpl<Poco::Data::Time>: public VarHolder
 	}
 
 private:
-	VarHolderImpl();
 	Poco::Data::Time _val;
 };
 

Data/testsuite/src/DataTest.h

@@ -40,7 +40,7 @@ class DataTest: public CppUnit::TestCase
 	void testColumnList();
 	void testRow();
 	void testRowSort();
-    void testSimpleRowFormatter();
+	void testSimpleRowFormatter();
 	void testJSONRowFormatter();
 	void testDateAndTime();
 	void testExternalBindingAndExtraction();