Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS proxy support (Second attempt) #3691

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Commits on Jul 9, 2022

  1. HTTPS Proxy support

    Jokser committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    0f85fdb View commit details
    Browse the repository at this point in the history
  2. HTTPS Proxy support

    Jokser committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    74acc46 View commit details
    Browse the repository at this point in the history
  3. Do not add default port for requests via proxy (fixes GCS via proxy t…

    …unnel usage)
    
    GCS server does not handle requests with port, and simply report an
    error:
    
        <?xml version="1.0"?>
        <?xml version='1.0' encoding='UTF-8'?>
        <Error>
            <Code>InvalidURI</Code>
            <Message>Couldn't parse the specified URI.</Message>
            <Details>Invalid URL: storage.googleapis.com:443/...</Details>
        </Error>
    
    Removing the port fixes the issue. Note that there is port in the Host
    header anyway.
    
    Note, this is a problem only for proxy in a tunnel mode, since only it
    sends such requests, other sends requests directly via HTTP methods.
    azat authored and Jokser committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    350d692 View commit details
    Browse the repository at this point in the history
  4. Formatting

    Jokser committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    dbb7949 View commit details
    Browse the repository at this point in the history
  5. Formatting

    Jokser committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    fdcd5b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Formatting

    Jokser committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    9660a96 View commit details
    Browse the repository at this point in the history
  2. Get rid of shared_ptr

    Jokser committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    b974e99 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7ebb259 View commit details
    Browse the repository at this point in the history
  4. Formatting

    Jokser committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    b8b6328 View commit details
    Browse the repository at this point in the history
  5. Formatting

    Jokser committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    2e60751 View commit details
    Browse the repository at this point in the history
  6. Test fix

    Jokser committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    86e750a View commit details
    Browse the repository at this point in the history
  7. Test fix

    Jokser committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    052c542 View commit details
    Browse the repository at this point in the history