-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPS proxy support (Second attempt) #3691
Open
Jokser
wants to merge
12
commits into
pocoproject:main
Choose a base branch
from
Jokser:https-proxy-support-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0f85fdb - Browse repository at this point
Copy the full SHA 0f85fdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74acc46 - Browse repository at this point
Copy the full SHA 74acc46View commit details -
Do not add default port for requests via proxy (fixes GCS via proxy t…
…unnel usage) GCS server does not handle requests with port, and simply report an error: <?xml version="1.0"?> <?xml version='1.0' encoding='UTF-8'?> <Error> <Code>InvalidURI</Code> <Message>Couldn't parse the specified URI.</Message> <Details>Invalid URL: storage.googleapis.com:443/...</Details> </Error> Removing the port fixes the issue. Note that there is port in the Host header anyway. Note, this is a problem only for proxy in a tunnel mode, since only it sends such requests, other sends requests directly via HTTP methods.
Configuration menu - View commit details
-
Copy full SHA for 350d692 - Browse repository at this point
Copy the full SHA 350d692View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbb7949 - Browse repository at this point
Copy the full SHA dbb7949View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdcd5b8 - Browse repository at this point
Copy the full SHA fdcd5b8View commit details
Commits on Jul 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9660a96 - Browse repository at this point
Copy the full SHA 9660a96View commit details -
Configuration menu - View commit details
-
Copy full SHA for b974e99 - Browse repository at this point
Copy the full SHA b974e99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ebb259 - Browse repository at this point
Copy the full SHA 7ebb259View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8b6328 - Browse repository at this point
Copy the full SHA b8b6328View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e60751 - Browse repository at this point
Copy the full SHA 2e60751View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86e750a - Browse repository at this point
Copy the full SHA 86e750aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 052c542 - Browse repository at this point
Copy the full SHA 052c542View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.